maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[SVE] Remove invalid usage of getNumElements in Instructions 

Summary:
Remove invalid usage of VectorType::getNumElements in
ShuffleVectorInst::isValidOperands identified by test case
llvm::Analysis/ConstantFolding/vscale-shufflevector.ll. The tested
conditions hold for both fixed width and scalable vectors; use
getElementCount().

Reviewers: efriedma, sdesmalen, c-rhodes, spatel

Reviewed By: sdesmalen

Subscribers: tschuett, hiraditya, rkruppe, psnobl, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D79212
This commit is contained in:
Christopher Tetreault 2020-05-04 08:29:08 -07:00
parent 015117411e
commit 3b7f3d012b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
llvm/lib/IR/Instructions.cpp
View File

@ -1916,11 +1916,11 @@ void ShuffleVectorInst::commute() {
bool ShuffleVectorInst::isValidOperands(const Value *V1, const Value *V2,
ArrayRef<int> Mask) {
// V1 and V2 must be vectors of the same type.
if (!V1->getType()->isVectorTy() || V1->getType() != V2->getType())
if (!isa<VectorType>(V1->getType()) || V1->getType() != V2->getType())
return false;
// Make sure the mask elements make sense.
int V1Size = cast<VectorType>(V1->getType())->getNumElements();
int V1Size = cast<VectorType>(V1->getType())->getElementCount().Min;
for (int Elem : Mask)
if (Elem != UndefMaskElem && Elem >= V1Size * 2)
return false;