maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Revert "[WebAssembly] Fix debug locations for ExplicitLocals pass" 

This reverts commit a66451ebbe.

This caused a failure when integrated with emscripten:
https://ci.chromium.org/ui/p/emscripten-releases/builders/try/linux/b8832019855439718609/overview
This commit is contained in:
Sam Clegg 2021-10-29 13:30:41 -07:00
parent 0121c96f37
commit 3b039c68f2
2 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
llvm/lib/Target/WebAssembly/WebAssemblyExplicitLocals.cpp
View File

@ -379,13 +379,8 @@ bool WebAssemblyExplicitLocals::runOnMachineFunction(MachineFunction &MF) {
const TargetRegisterClass *RC = MRI.getRegClass(OldReg);
Register NewReg = MRI.createVirtualRegister(RC);
unsigned Opc = getLocalGetOpcode(RC);
// Use a blank DebugLoc, because InsertPt may be discontinuous from
// the usage of this value, causing non-linear stepping in the
// debugger or function entry points where variables aren't live yet.
// See crbug.com/1251909, crbug.com/1249745
DebugLoc DL;
InsertPt =
BuildMI(MBB, InsertPt, DL, TII->get(Opc), NewReg)
BuildMI(MBB, InsertPt, MI.getDebugLoc(), TII->get(Opc), NewReg)
.addImm(LocalId);
MO.setReg(NewReg);
MFI.stackifyVReg(MRI, NewReg);

4
llvm/test/MC/WebAssembly/debug-localvar.ll
View File

@ -101,8 +101,8 @@ attributes #2 = { nounwind }
; CHECK-NEXT: DW_AT_type (0x00000073 "int")
; CHECK-LABEL: DW_TAG_lexical_block
; CHECK-NEXT: DW_AT_low_pc (0x0000001e)
; CHECK-NEXT: DW_AT_high_pc (0x0000002f)
; CHECK-NEXT: DW_AT_low_pc (0x0000001c)
; CHECK-NEXT: DW_AT_high_pc (0x0000002d)
; CHECK-LABEL: DW_TAG_variable
; CHECK-NEXT: DW_AT_location (DW_OP_fbreg +4)