maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Fix CMICmdArgValPrintValues::Validate & enable 4 tests that were XFAIL'ed in r237437 (MI) 

llvm-svn: 237443
This commit is contained in:
Ilia K 2015-05-15 12:33:04 +00:00
parent 734400b46a
commit 3ac979c4da
3 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lldb/test/tools/lldb-mi/stack/TestMiStack.py
View File

@ -11,7 +11,6 @@ class MiStackTestCase(lldbmi_testcase.MiTestCaseBase):
mydir = TestBase.compute_mydir(__file__)
@lldbmi_test
@expectedFailureLinux # The print-values argument can't be parsed correctly on Linux
@expectedFailureWindows("llvm.org/pr22274: need a pexpect replacement for windows")
@skipIfFreeBSD # llvm.org/pr22411: Failure presumably due to known thread races
def test_lldbmi_stack_list_arguments(self):
@ -74,7 +73,6 @@ class MiStackTestCase(lldbmi_testcase.MiTestCaseBase):
self.expect("\^error,msg=\"Command 'stack-list-arguments'\. Thread frame range invalid\"")
@lldbmi_test
@expectedFailureLinux # The print-values argument can't be parsed correctly on Linux
@expectedFailureWindows("llvm.org/pr22274: need a pexpect replacement for windows")
@skipIfFreeBSD # llvm.org/pr22411: Failure presumably due to known thread races
def test_lldbmi_stack_list_locals(self):
@ -202,7 +200,6 @@ class MiStackTestCase(lldbmi_testcase.MiTestCaseBase):
self.expect("\^done,locals=\[{name=\"test_str\",value=\".*?Rakaposhi.*?\"},{name=\"var_e\",value=\"24\"},{name=\"ptr\",value=\".*?\"}\]")
@lldbmi_test
@expectedFailureLinux # The print-values argument can't be parsed correctly on Linux
@expectedFailureWindows("llvm.org/pr22274: need a pexpect replacement for windows")
@skipIfFreeBSD # llvm.org/pr22411: Failure presumably due to known thread races
def test_lldbmi_stack_list_variables(self):

1
lldb/test/tools/lldb-mi/variable/TestMiVar.py
View File

@ -11,7 +11,6 @@ class MiVarTestCase(lldbmi_testcase.MiTestCaseBase):
mydir = TestBase.compute_mydir(__file__)
@lldbmi_test
@expectedFailureLinux # The print-values argument can't be parsed correctly on Linux
@expectedFailureWindows("llvm.org/pr22274: need a pexpect replacement for windows")
@skipIfFreeBSD # llvm.org/pr22411: Failure presumably due to known thread races
def test_lldbmi_eval(self):

6
lldb/tools/lldb-mi/MICmdArgValPrintValues.cpp
View File

@ -64,13 +64,13 @@ CMICmdArgValPrintValues::Validate(CMICmdArgContext &vwArgContext)
if (vwArgContext.IsEmpty())
return MIstatus::success;
const CMIUtilString &rArg(vwArgContext.GetArgs()[0]);
if (IsArgPrintValues(rArg) && ExtractPrintValues(rArg))
const CMIUtilString strArg(vwArgContext.GetArgs()[0]);
if (IsArgPrintValues(strArg) && ExtractPrintValues(strArg))
{
m_bFound = true;
m_bValid = true;
m_argValue = GetPrintValues();
vwArgContext.RemoveArg(rArg);
vwArgContext.RemoveArg(strArg);
return MIstatus::success;
}