[DAG] isGuaranteedNotToBeUndefOrPoison - handle ISD::BUILD_VECTOR nodes

If all demanded elements of the BUILD_VECTOR pass a isGuaranteedNotToBeUndefOrPoison check, then we can treat this specific demanded use of the BUILD_VECTOR as guaranteed not to be undef or poison either.

Differential Revision: https://reviews.llvm.org/D107174
This commit is contained in:
Simon Pilgrim 2021-07-31 15:08:13 +01:00
parent bc2cb91a20
commit 3a7c82efb8
3 changed files with 12 additions and 5 deletions

View File

@ -4285,7 +4285,17 @@ bool SelectionDAG::isGuaranteedNotToBeUndefOrPoison(SDValue Op,
case ISD::UNDEF:
return PoisonOnly;
// TODO: ISD::BUILD_VECTOR handling
case ISD::BUILD_VECTOR:
// NOTE: BUILD_VECTOR has implicit truncation of wider scalar elements -
// this shouldn't affect the result.
for (unsigned i = 0, e = Op.getNumOperands(); i < e; ++i) {
if (!DemandedElts[i])
continue;
if (!isGuaranteedNotToBeUndefOrPoison(Op.getOperand(i), PoisonOnly,
Depth + 1))
return false;
}
return true;
// TODO: Search for noundef attributes from library functions.

View File

@ -15,7 +15,6 @@ define i32 @fold_add_freeze_i32() {
ret i32 %5
}
; FIXME: X86 scalarization sees through the freeze, but vector types don't.
define <4 x i32> @fold_add_freeze_v4i32() {
; X86-LABEL: fold_add_freeze_v4i32:
; X86: # %bb.0:
@ -28,9 +27,7 @@ define <4 x i32> @fold_add_freeze_v4i32() {
;
; X64-LABEL: fold_add_freeze_v4i32:
; X64: # %bb.0:
; X64-NEXT: pxor %xmm1, %xmm1
; X64-NEXT: pcmpeqd %xmm0, %xmm0
; X64-NEXT: paddd %xmm1, %xmm0
; X64-NEXT: retq
%1 = insertelement <4 x i32> poison, i32 0, i32 0
%2 = shufflevector <4 x i32> %1, <4 x i32> poison, <4 x i32> zeroinitializer

View File

@ -46,7 +46,7 @@ define i10 @promote() {
define <2 x i10> @promote_vec() {
; CHECK-LABEL: promote_vec:
; CHECK: ## %bb.0:
; CHECK-NEXT: movw $1674, %ax ## imm = 0x68A
; CHECK-NEXT: movw $650, %ax ## imm = 0x28A
; CHECK-NEXT: movw $518, %dx ## imm = 0x206
; CHECK-NEXT: retl
%a = freeze <2 x i10> <i10 682, i10 125>