maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[AArch64][ASMParser] Refuse equal source/destination for LDRAA/LDRAB 

Differential Revision: https://reviews.llvm.org/D74822
This commit is contained in:
Pierre-vh 2020-02-19 09:46:50 +00:00
parent 53eece04bd
commit 39cecabece
3 changed files with 30 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
View File

@ -4114,6 +4114,16 @@ bool AArch64AsmParser::validateInstruction(MCInst &Inst, SMLoc &IDLoc,
"unpredictable STXP instruction, status is also a source");
break;
}
case AArch64::LDRABwriteback:
case AArch64::LDRAAwriteback: {
unsigned Xt = Inst.getOperand(0).getReg();
unsigned Xn = Inst.getOperand(1).getReg();
if (Xt == Xn)
return Error(Loc[0],
"unpredictable LDRA instruction, writeback base"
" is also a destination");
break;
}
}

12
llvm/test/MC/AArch64/armv8.3a-diagnostics.s
View File

@ -18,3 +18,15 @@
// CHECK: error: index must be a multiple of 8 in range [-4096, 4088].
ldrab x0, [x1, 4086]
// CHECK: error: index must be a multiple of 8 in range [-4096, 4088].
ldraa x0, [x0, -4096]!
// CHECK: [[@LINE-1]]:{{[0-9]+}}: error: unpredictable LDRA instruction, writeback base is also a destination
ldrab x0, [x0, -4096]!
// CHECK: [[@LINE-1]]:{{[0-9]+}}: error: unpredictable LDRA instruction, writeback base is also a destination
ldraa xzr, [xzr, -4096]!
// CHECK: [[@LINE-1]]:{{[0-9]+}}: error: invalid operand for instruction
ldraa sp, [sp, -4096]!
// CHECK: [[@LINE-1]]:{{[0-9]+}}: error: invalid operand for instruction
ldrab xzr, [xzr, -4096]!
// CHECK: [[@LINE-1]]:{{[0-9]+}}: error: invalid operand for instruction
ldrab sp, [sp, -4096]!
// CHECK: [[@LINE-1]]:{{[0-9]+}}: error: invalid operand for instruction

8
llvm/test/MC/AArch64/armv8.3a-signed-pointer.s
View File

@ -327,3 +327,11 @@
// CHECK-NEXT: ldrab x0, [x1, #0]! // encoding: [0x20,0x0c,0xa0,0xf8]
// CHECK-REQ: error: instruction requires: pa
// CHECK-REQ-NEXT: ldrab x0, [x1]!
ldraa xzr, [sp, -4096]!
// CHECK-NEXT: ldraa xzr, [sp, #-4096]! // encoding: [0xff,0x0f,0x60,0xf8]
// CHECK-REQ: error: instruction requires: pa
// CHECK-REQ-NEXT: ldraa xzr, [sp, -4096]!
ldrab xzr, [sp, -4096]!
// CHECK-NEXT: ldrab xzr, [sp, #-4096]! // encoding: [0xff,0x0f,0xe0,0xf8]
// CHECK-REQ: error: instruction requires: pa
// CHECK-REQ-NEXT: ldrab xzr, [sp, -4096]!