diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/TestLinuxCore.py b/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/TestLinuxCore.py new file mode 100644 index 000000000000..3efd3ec3f7bb --- /dev/null +++ b/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/TestLinuxCore.py @@ -0,0 +1,45 @@ +""" +Test basics of linux core file debugging. +""" + +from __future__ import print_function + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + +class LinuxCoreTestCase(TestBase): + + mydir = TestBase.compute_mydir(__file__) + + @skipIf(bugnumber="llvm.org/pr26947") + @no_debug_info_test + def test_i386(self): + """Test that lldb can read the process information from an i386 linux core file.""" + self.do_test("i386", 32306) + + @no_debug_info_test + def test_x86_64(self): + """Test that lldb can read the process information from an x86_64 linux core file.""" + self.do_test("x86_64", 32259) + + def do_test(self, arch, pid): + target = self.dbg.CreateTarget(arch + ".out") + process = target.LoadCore(arch + ".core") + self.assertTrue(process, PROCESS_IS_VALID) + self.assertEqual(process.GetNumThreads(), 1) + self.assertEqual(process.GetProcessID(), pid) + + thread = process.GetSelectedThread() + self.assertTrue(thread) + self.assertEqual(thread.GetThreadID(), pid) + backtrace = ["bar", "foo", "_start"] + self.assertEqual(thread.GetNumFrames(), len(backtrace)) + for i in range(len(backtrace)): + frame = thread.GetFrameAtIndex(i) + self.assertTrue(frame) + self.assertEqual(frame.GetFunctionName(), backtrace[i]) + self.assertEqual(frame.GetLineEntry().GetLine(), + line_number("main.c", "Frame " + backtrace[i])) + self.assertEqual(frame.FindVariable("F").GetValueAsUnsigned(), ord(backtrace[i][0])) diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/i386.core b/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/i386.core new file mode 100644 index 000000000000..f8deff474d1f Binary files /dev/null and b/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/i386.core differ diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/i386.out b/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/i386.out new file mode 100755 index 000000000000..3cdd4eeca103 Binary files /dev/null and b/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/i386.out differ diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/main.c b/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/main.c new file mode 100644 index 000000000000..f5bde4171ca5 --- /dev/null +++ b/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/main.c @@ -0,0 +1,17 @@ +static void bar(char *boom) +{ + char F = 'b'; + *boom = 47; // Frame bar +} + +static void foo(char *boom, void (*boomer)(char *)) +{ + char F = 'f'; + boomer(boom); // Frame foo +} + +void _start(void) +{ + char F = '_'; + foo(0, bar); // Frame _start +} diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/make-core.sh b/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/make-core.sh new file mode 100755 index 000000000000..10f5f06c5052 --- /dev/null +++ b/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/make-core.sh @@ -0,0 +1,32 @@ +#! /bin/bash + +set -e -x + +if grep -q '^|' smaller core files. +exec ./a.out diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/x86_64.core b/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/x86_64.core new file mode 100644 index 000000000000..e2fa69e4558e Binary files /dev/null and b/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/x86_64.core differ diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/x86_64.out b/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/x86_64.out new file mode 100755 index 000000000000..842402fd519d Binary files /dev/null and b/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/x86_64.out differ diff --git a/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp b/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp index db56cc38140e..fb54153a9194 100644 --- a/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp +++ b/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp @@ -559,11 +559,10 @@ ProcessElfCore::ParseThreadContextsFromNoteSegment(const elf::ELFProgramHeader * have_prstatus = true; prstatus.Parse(note_data, arch); thread_data->signo = prstatus.pr_cursig; + thread_data->tid = prstatus.pr_pid; header_size = ELFLinuxPrStatus::GetSize(arch); len = note_data.GetByteSize() - header_size; thread_data->gpregset = DataExtractor(note_data, header_size, len); - // FIXME: Obtain actual tid on Linux - thread_data->tid = m_thread_data.size(); break; case NT_FPREGSET: thread_data->fpregset = note_data; @@ -572,6 +571,7 @@ ProcessElfCore::ParseThreadContextsFromNoteSegment(const elf::ELFProgramHeader * have_prpsinfo = true; prpsinfo.Parse(note_data, arch); thread_data->name = prpsinfo.pr_fname; + SetID(prpsinfo.pr_pid); break; case NT_AUXV: m_auxv = DataExtractor(note_data);