maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Missed a few places where we need to report unreadable executables. 

<rdar://problem/17727734>

llvm-svn: 215743
This commit is contained in:
Greg Clayton 2014-08-15 18:03:30 +00:00
parent 1a0b735340
commit 39945dcc0b
6 changed files with 66 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp
View File

@ -287,10 +287,17 @@ PlatformFreeBSD::ResolveExecutable (const FileSpec &exe_file,
if (error.Fail() || !exe_module_sp)
{
error.SetErrorStringWithFormat ("'%s' doesn't contain any '%s' platform architectures: %s",
exe_file.GetPath().c_str(),
GetPluginName().GetCString(),
arch_names.GetString().c_str());
if (exe_file.Readable())
{
error.SetErrorStringWithFormat ("'%s' doesn't contain any '%s' platform architectures: %s",
exe_file.GetPath().c_str(),
GetPluginName().GetCString(),
arch_names.GetString().c_str());
}
else
{
error.SetErrorStringWithFormat("'%s' is not readable", exe_file.GetPath().c_str());
}
}
}
}

15
lldb/source/Plugins/Platform/Kalimba/PlatformKalimba.cpp
View File

@ -184,10 +184,17 @@ PlatformKalimba::ResolveExecutable (const FileSpec &exe_file,
if (error.Fail() || !exe_module_sp)
{
error.SetErrorStringWithFormat ("'%s' doesn't contain any '%s' platform architectures: %s",
exe_file.GetPath().c_str(),
GetPluginName().GetCString(),
arch_names.GetString().c_str());
if (exe_file.Readable())
{
error.SetErrorStringWithFormat ("'%s' doesn't contain any '%s' platform architectures: %s",
exe_file.GetPath().c_str(),
GetPluginName().GetCString(),
arch_names.GetString().c_str());
}
else
{
error.SetErrorStringWithFormat("'%s' is not readable", exe_file.GetPath().c_str());
}
}
}
}

15
lldb/source/Plugins/Platform/Linux/PlatformLinux.cpp
View File

@ -301,10 +301,17 @@ PlatformLinux::ResolveExecutable (const FileSpec &exe_file,
if (error.Fail() || !exe_module_sp)
{
error.SetErrorStringWithFormat ("'%s' doesn't contain any '%s' platform architectures: %s",
exe_file.GetPath().c_str(),
GetPluginName().GetCString(),
arch_names.GetString().c_str());
if (exe_file.Readable())
{
error.SetErrorStringWithFormat ("'%s' doesn't contain any '%s' platform architectures: %s",
exe_file.GetPath().c_str(),
GetPluginName().GetCString(),
arch_names.GetString().c_str());
}
else
{
error.SetErrorStringWithFormat("'%s' is not readable", exe_file.GetPath().c_str());
}
}
}
}

15
lldb/source/Plugins/Platform/MacOSX/PlatformRemoteiOS.cpp
View File

@ -273,10 +273,17 @@ PlatformRemoteiOS::ResolveExecutable (const FileSpec &exe_file,
if (error.Fail() || !exe_module_sp)
{
error.SetErrorStringWithFormat ("'%s' doesn't contain any '%s' platform architectures: %s",
exe_file.GetPath().c_str(),
GetPluginName().GetCString(),
arch_names.GetString().c_str());
if (exe_file.Readable())
{
error.SetErrorStringWithFormat ("'%s' doesn't contain any '%s' platform architectures: %s",
exe_file.GetPath().c_str(),
GetPluginName().GetCString(),
arch_names.GetString().c_str());
}
else
{
error.SetErrorStringWithFormat("'%s' is not readable", exe_file.GetPath().c_str());
}
}
}
else

15
lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp
View File

@ -238,10 +238,17 @@ PlatformiOSSimulator::ResolveExecutable (const FileSpec &exe_file,
if (error.Fail() || !exe_module_sp)
{
error.SetErrorStringWithFormat ("'%s' doesn't contain any '%s' platform architectures: %s",
exe_file.GetPath().c_str(),
GetPluginName().GetCString(),
arch_names.GetString().c_str());
if (exe_file.Readable())
{
error.SetErrorStringWithFormat ("'%s' doesn't contain any '%s' platform architectures: %s",
exe_file.GetPath().c_str(),
GetPluginName().GetCString(),
arch_names.GetString().c_str());
}
else
{
error.SetErrorStringWithFormat("'%s' is not readable", exe_file.GetPath().c_str());
}
}
}
else

15
lldb/source/Plugins/Platform/Windows/PlatformWindows.cpp
View File

@ -294,10 +294,17 @@ PlatformWindows::ResolveExecutable (const FileSpec &exe_file,
if (error.Fail() || !exe_module_sp)
{
error.SetErrorStringWithFormat ("'%s' doesn't contain any '%s' platform architectures: %s",
exe_file.GetPath().c_str(),
GetPluginName().GetCString(),
arch_names.GetString().c_str());
if (exe_file.Readable())
{
error.SetErrorStringWithFormat ("'%s' doesn't contain any '%s' platform architectures: %s",
exe_file.GetPath().c_str(),
GetPluginName().GetCString(),
arch_names.GetString().c_str());
}
else
{
error.SetErrorStringWithFormat("'%s' is not readable", exe_file.GetPath().c_str());
}
}
}
}