[CodeGen] Clarify comment about COFF common symbol alignment

After a discussion on the commit thread, it seems the 32 byte alignment
limitation is an MSVC toolchain artifact, not an inherent COFF
restriction. Clarify the comment accordingly, since saying COFF in the
comment but using isKnownWindowsMSVCEnvironment in the conditional is
confusing. Also add a newline before the comment, which is consistent
with the local style.

Differential Revision: https://reviews.llvm.org/D56466

llvm-svn: 350754
This commit is contained in:
Shoaib Meenai 2019-01-09 20:05:16 +00:00
parent ac6454a7f6
commit 39287e759f
1 changed files with 6 additions and 2 deletions

View File

@ -3761,8 +3761,12 @@ static bool isVarDeclStrongDefinition(const ASTContext &Context,
}
}
}
// COFF doesn't support alignments greater than 32, so these cannot be
// in common.
// Microsoft's link.exe doesn't support alignments greater than 32 for common
// symbols, so symbols with greater alignment requirements cannot be common.
// Other COFF linkers (ld.bfd and LLD) support arbitrary power-of-two
// alignments for common symbols via the aligncomm directive, so this
// restriction only applies to MSVC environments.
if (Context.getTargetInfo().getTriple().isKnownWindowsMSVCEnvironment() &&
Context.getTypeAlignIfKnown(D->getType()) > 32)
return true;