maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Make crashlog.py less noisy 

For end-users there is no point in printing dSYM load errors for
system frameworks, since they will all fail and there's nothing they
can do about it. This patch hides them by default and shows them when
--verbose is present.

Differential Revision: https://reviews.llvm.org/D63310

llvm-svn: 363412
This commit is contained in:
Adrian Prantl 2019-06-14 15:39:11 +00:00
parent 75312aa805
commit 38be2c65b6
1 changed files with 27 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
lldb/examples/python/crashlog.py
View File

@ -246,7 +246,8 @@ class CrashLog(symbolication.Symbolicator):
identifier, identifier,
version, version,
uuid, uuid,
path): path,
verbose):
symbolication.Image.__init__(self, path, uuid) symbolication.Image.__init__(self, path, uuid)
self.add_section( self.add_section(
symbolication.Section( symbolication.Section(
@ -255,6 +256,17 @@ class CrashLog(symbolication.Symbolicator):
"__TEXT")) "__TEXT"))
self.identifier = identifier self.identifier = identifier
self.version = version self.version = version
self.verbose = verbose
def show_symbol_progress(self):
"""
Hide progress output and errors from system frameworks as they are plentiful.
"""
if self.verbose:
return True
return not (self.path.startswith("/System/Library/") or
self.path.startswith("/usr/lib/"))
def find_matching_slice(self): def find_matching_slice(self):
dwarfdump_cmd_output = subprocess.check_output( dwarfdump_cmd_output = subprocess.check_output(
@ -271,8 +283,9 @@ class CrashLog(symbolication.Symbolicator):
return True return True
if not self.resolved_path: if not self.resolved_path:
self.unavailable = True self.unavailable = True
print(("error\n error: unable to locate '%s' with UUID %s" if self.show_symbol_progress():
% (self.path, self.get_normalized_uuid_string()))) print(("error\n error: unable to locate '%s' with UUID %s"
% (self.path, self.get_normalized_uuid_string())))
return False return False
def locate_module_and_debug_symbols(self): def locate_module_and_debug_symbols(self):
@ -282,7 +295,8 @@ class CrashLog(symbolication.Symbolicator):
# Mark this as resolved so we don't keep trying # Mark this as resolved so we don't keep trying
self.resolved = True self.resolved = True
uuid_str = self.get_normalized_uuid_string() uuid_str = self.get_normalized_uuid_string()
print('Getting symbols for %s %s...' % (uuid_str, self.path), end=' ') if self.show_symbol_progress():
print('Getting symbols for %s %s...' % (uuid_str, self.path), end=' ')
if os.path.exists(self.dsymForUUIDBinary): if os.path.exists(self.dsymForUUIDBinary):
dsym_for_uuid_command = '%s %s' % ( dsym_for_uuid_command = '%s %s' % (
self.dsymForUUIDBinary, uuid_str) self.dsymForUUIDBinary, uuid_str)
@ -332,7 +346,7 @@ class CrashLog(symbolication.Symbolicator):
self.unavailable = True self.unavailable = True
return False return False
def __init__(self, path): def __init__(self, path, verbose):
"""CrashLog constructor that take a path to a darwin crash log file""" """CrashLog constructor that take a path to a darwin crash log file"""
symbolication.Symbolicator.__init__(self) symbolication.Symbolicator.__init__(self)
self.path = os.path.expanduser(path) self.path = os.path.expanduser(path)
@ -345,6 +359,7 @@ class CrashLog(symbolication.Symbolicator):
self.version = -1 self.version = -1
self.error = None self.error = None
self.target = None self.target = None
self.verbose = verbose
# With possible initial component of ~ or ~user replaced by that user's # With possible initial component of ~ or ~user replaced by that user's
# home directory. # home directory.
try: try:
@ -491,7 +506,8 @@ class CrashLog(symbolication.Symbolicator):
img_name.strip(), img_name.strip(),
img_version.strip() img_version.strip()
if img_version else "", if img_version else "",
uuid.UUID(img_uuid), img_path) uuid.UUID(img_uuid), img_path,
self.verbose)
self.images.append(image) self.images.append(image)
else: else:
print("error: image regex failed for: %s" % line) print("error: image regex failed for: %s" % line)
@ -557,7 +573,9 @@ class CrashLog(symbolication.Symbolicator):
if self.target: if self.target:
return self.target # success return self.target # success
print('crashlog.create_target()...4') print('crashlog.create_target()...4')
print('error: unable to locate any executables from the crash log') print('error: Unable to locate any executables from the crash log.')
print(' Try loading the executable into lldb before running crashlog')
print(' and/or make sure the .dSYM bundles can be found by Spotlight.')
return self.target return self.target
def get_target(self): def get_target(self):
@ -683,7 +701,7 @@ def interactive_crashlogs(options, args):
crash_logs = list() crash_logs = list()
for crash_log_file in crash_log_files: for crash_log_file in crash_log_files:
# print 'crash_log_file = "%s"' % crash_log_file # print 'crash_log_file = "%s"' % crash_log_file
crash_log = CrashLog(crash_log_file) crash_log = CrashLog(crash_log_file, options.verbose)
if crash_log.error: if crash_log.error:
print(crash_log.error) print(crash_log.error)
continue continue
@ -1022,7 +1040,7 @@ be disassembled and lookups can be performed using the addresses found in the cr
interactive_crashlogs(options, args) interactive_crashlogs(options, args)
else: else:
for crash_log_file in args: for crash_log_file in args:
crash_log = CrashLog(crash_log_file) crash_log = CrashLog(crash_log_file, options.verbose)
SymbolicateCrashLog(crash_log, options) SymbolicateCrashLog(crash_log, options)
if __name__ == '__main__': if __name__ == '__main__':
# Create a new debugger instance # Create a new debugger instance