[lldb] Remove redundant access specifiers (NFC)

lldb/include/lldb/Core/SearchFilter.h

@@ -398,7 +398,6 @@ public:
 protected:
   lldb::SearchFilterSP DoCreateCopy() override;
 
-protected:
   FileSpecList m_module_spec_list;
 };
 

lldb/include/lldb/Core/ValueObjectChild.h

@@ -75,7 +75,6 @@ protected:
   //  void
   //  ReadValueFromMemory (ValueObject* parent, lldb::addr_t address);
 
-protected:
   friend class ValueObject;
   friend class ValueObjectConstResult;
   friend class ValueObjectConstResultImpl;

lldb/include/lldb/DataFormatters/DumpValueObjectOptions.h

@@ -127,7 +127,6 @@ public:
   DumpValueObjectOptions &
   SetPointerAsArray(const PointerAsArraySettings &ptr_array);
 
-public:
   uint32_t m_max_depth = UINT32_MAX;
   lldb::DynamicValueType m_use_dynamic = lldb::eNoDynamicValues;
   uint32_t m_omit_summary_depth = 0;

lldb/include/lldb/DataFormatters/FormatClasses.h

@@ -151,7 +151,6 @@ private:
   };
   TypeOrName m_type;
 
-private:
   TypeNameSpecifierImpl(const TypeNameSpecifierImpl &) = delete;
   const TypeNameSpecifierImpl &
   operator=(const TypeNameSpecifierImpl &) = delete;

lldb/include/lldb/Host/Editline.h

@@ -326,7 +326,6 @@ private:
 
   void ApplyTerminalSizeChange();
 
-private:
 #if LLDB_EDITLINE_USE_WCHAR
   std::wstring_convert<std::codecvt_utf8<wchar_t>> m_utf8conv;
 #endif

lldb/include/lldb/Host/MainLoopBase.h

@@ -79,7 +79,6 @@ private:
     const ReadHandle &operator=(const ReadHandle &) = delete;
   };
 
-private:
   MainLoopBase(const MainLoopBase &) = delete;
   const MainLoopBase &operator=(const MainLoopBase &) = delete;
 };

lldb/include/lldb/Symbol/DebugMacros.h

@@ -27,7 +27,6 @@ public:
       INVALID, DEFINE, UNDEF, START_FILE, END_FILE, INDIRECT
   };
 
-public:
   static DebugMacroEntry CreateDefineEntry(uint32_t line, const char *str);
 
   static DebugMacroEntry CreateUndefEntry(uint32_t line, const char *str);

lldb/include/lldb/Symbol/UnwindPlan.h

@@ -320,7 +320,6 @@ public:
       } m_value;
     }; // class FAValue
 
-  public:
     Row();
 
     Row(const UnwindPlan::Row &rhs) = default;
@@ -375,7 +374,6 @@ public:
     collection m_register_locations;
   }; // class Row
 
-public:
   typedef std::shared_ptr<Row> RowSP;
 
   UnwindPlan(lldb::RegisterKind reg_kind)

lldb/include/lldb/Target/Process.h

@@ -1331,7 +1331,6 @@ public:
 
   virtual bool GetProcessInfo(ProcessInstanceInfo &info);
 
-public:
   /// Get the exit status for a process.
   ///
   /// \return

lldb/include/lldb/Target/Thread.h

@@ -1258,7 +1258,6 @@ private:
                                 // for this thread?
   StructuredData::ObjectSP m_extended_info; // The extended info for this thread
 
-private:
   void BroadcastSelectedFrameChange(StackID &new_frame_id);
 
   Thread(const Thread &) = delete;

lldb/include/lldb/Target/ThreadPlan.h

@@ -615,7 +615,6 @@ private:
 
   lldb::ThreadPlanTracerSP m_tracer_sp;
 
-private:
   ThreadPlan(const ThreadPlan &) = delete;
   const ThreadPlan &operator=(const ThreadPlan &) = delete;
 };

lldb/include/lldb/Utility/DataEncoder.h

@@ -225,7 +225,6 @@ private:
   ///     The total number of bytes of data this object refers to.
   size_t GetByteSize() const { return m_end - m_start; }
 
-private:
   /// A pointer to the first byte of data.
   uint8_t *m_start;
 

lldb/source/Commands/CommandObjectCommands.cpp

@@ -1621,7 +1621,6 @@ protected:
     io_handler.SetIsDone(true);
   }
 
-protected:
   bool DoExecute(Args &command, CommandReturnObject &result) override {
     if (GetDebugger().GetScriptLanguage() != lldb::eScriptLanguagePython) {
       result.AppendError("only scripting language supported for scripted "

lldb/source/Commands/CommandObjectFrame.cpp

@@ -186,7 +186,6 @@ protected:
     return true;
   }
 
-protected:
   CommandOptions m_options;
 };
 
@@ -379,7 +378,6 @@ protected:
     return result.Succeeded();
   }
 
-protected:
   CommandOptions m_options;
 };
 
@@ -714,7 +712,6 @@ protected:
     return res;
   }
 
-protected:
   OptionGroupOptions m_option_group;
   OptionGroupVariable m_option_variable;
   OptionGroupFormat m_option_format;

lldb/source/Commands/CommandObjectPlatform.cpp

@@ -422,7 +422,6 @@ protected:
     return &m_options;
   }
 
-protected:
   OptionGroupOptions m_options;
   OptionGroupFile m_option_working_dir;
 };
@@ -1023,7 +1022,6 @@ protected:
     return result.Succeeded();
   }
 
-protected:
   ProcessLaunchCommandOptions m_options;
 };
 

lldb/source/Commands/CommandObjectProcess.cpp

@@ -249,7 +249,6 @@ protected:
     return result.Succeeded();
   }
 
-protected:
   ProcessLaunchCommandOptions m_options;
 };
 

lldb/source/Commands/CommandObjectThread.cpp

@@ -775,7 +775,6 @@ protected:
     return result.Succeeded();
   }
 
-protected:
   StepType m_step_type;
   StepScope m_step_scope;
   ThreadStepScopeOptionGroup m_options;

lldb/source/Plugins/ExpressionParser/Clang/ClangASTImporter.h

@@ -144,7 +144,6 @@ public:
   void ForgetDestination(clang::ASTContext *dst_ctx);
   void ForgetSource(clang::ASTContext *dst_ctx, clang::ASTContext *src_ctx);
 
-public:
   struct DeclOrigin {
     DeclOrigin() : ctx(nullptr), decl(nullptr) {}
 
@@ -315,7 +314,6 @@ public:
     return delegate_iter->second;
   }
 
-public:
   DeclOrigin GetDeclOrigin(const clang::Decl *decl);
 
   clang::FileManager m_file_manager;

lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.h

@@ -333,7 +333,6 @@ public:
   ///     global lookup for performance reasons.
   bool IgnoreName(const ConstString name, bool ignore_all_dollar_names);
 
-public:
   /// Copies a single Decl into the parser's AST context.
   ///
   /// \param[in] src_decl

lldb/source/Plugins/Language/ObjC/CFBasicHash.h

@@ -60,7 +60,6 @@ private:
 
   size_t GetPointerCount() const;
 
-private:
   uint32_t m_ptr_size = UINT32_MAX;
   lldb::ByteOrder m_byte_order = lldb::eByteOrderInvalid;
   Address m_address = LLDB_INVALID_ADDRESS;

lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.h

@@ -99,7 +99,6 @@ private:
 
       void Dump(Stream &s);
 
-    public:
       bool m_valid;
       AppleObjCVTables *m_owner;
       lldb::addr_t m_header_addr;

lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h

@@ -293,7 +293,6 @@ protected:
 private:
   bool CreateBinary();
 
-private:
   dos_header_t m_dos_header;
   coff_header_t m_coff_header;
   coff_opt_header_t m_coff_header_opt;

lldb/source/Plugins/Process/Utility/RegisterInfoInterface.h

@@ -61,7 +61,6 @@ public:
     return nullptr;
   }
 
-public:
   // FIXME make private.
   lldb_private::ArchSpec m_target_arch;
 };

lldb/source/Plugins/Process/minidump/MinidumpParser.h

@@ -100,7 +100,6 @@ private:
   MinidumpParser(lldb::DataBufferSP data_sp,
                  std::unique_ptr<llvm::object::MinidumpFile> file);
 
-private:
   lldb::DataBufferSP m_data_sp;
   std::unique_ptr<llvm::object::MinidumpFile> m_file;
   ArchSpec m_arch;

lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h

@@ -321,7 +321,6 @@ public:
 
   StructuredData::ObjectSP CreateStructuredObject() const;
 
-public:
   template <typename... T>
   llvm::Expected<PythonObject> CallMethod(const char *name,
                                           const T &... t) const {