maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[analyzer][NFC] Make the API of CallDescription safer slightly 

The new //deleted// constructor overload makes sure that no implicit
conversion from `0` would happen to `ArrayRef<const char*>`.

Also adds nodiscard to the `CallDescriptionMap::lookup()`
This commit is contained in:
Balazs Benics 2021-11-17 15:55:35 +01:00
parent 8924ba3bf8
commit 35ff3a0095
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallDescription.h
View File

@ -18,6 +18,7 @@
#include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h"
#include "llvm/ADT/ArrayRef.h"
#include "llvm/ADT/Optional.h"
#include "llvm/Support/Compiler.h"
#include <vector>
namespace clang {
@ -67,6 +68,8 @@ public:
Optional<unsigned> RequiredArgs = None,
Optional<size_t> RequiredParams = None);
CallDescription(std::nullptr_t) = delete;
/// Get the name of the function that this object matches.
StringRef getFunctionName() const { return QualifiedName.back(); }
@ -104,7 +107,7 @@ public:
CallDescriptionMap(const CallDescriptionMap &) = delete;
CallDescriptionMap &operator=(const CallDescription &) = delete;
const T *lookup(const CallEvent &Call) const {
LLVM_NODISCARD const T *lookup(const CallEvent &Call) const {
// Slow path: linear lookup.
// TODO: Implement some sort of fast path.
for (const std::pair<CallDescription, T> &I : LinearMap)