maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[clang-tidy] cppcoreguidelines-pro-type-member-init: suppress warning for default member funcs 

Modify the cppcoreguidelines-pro-type-member-init checker to ignore warnings from the move and copy-constructors when they are compiler defined with `= default` outside of the type declaration.

Reported as [LLVM bug 36819](https://bugs.llvm.org/show_bug.cgi?id=36819)

Reviewed By: malcolm.parsons

Differential Revision: https://reviews.llvm.org/D93333
This commit is contained in:
Chris Warner 2020-12-20 11:11:27 +00:00 committed by Malcolm Parsons
parent 99562332e3
commit 35f2c3a8b4
2 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp
View File

@ -297,6 +297,10 @@ void ProTypeMemberInitCheck::check(const MatchFinder::MatchResult &Result) {
// Skip declarations delayed by late template parsing without a body.
if (!Ctor->getBody())
return;
// Skip out-of-band explicitly defaulted special member functions
// (except the default constructor).
if (Ctor->isExplicitlyDefaulted() && !Ctor->isDefaultConstructor())
return;
checkMissingMemberInitializer(*Result.Context, *Ctor->getParent(), Ctor);
checkMissingBaseClassInitializer(*Result.Context, *Ctor->getParent(), Ctor);
} else if (const auto *Record =

16
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-member-init.cpp
View File

@ -501,3 +501,19 @@ struct NegativeImplicitInheritedCtor : NegativeImplicitInheritedCtorBase {
void Bug33557() {
NegativeImplicitInheritedCtor I(5);
}
struct NegativeDefaultedCtorOutOfDecl {
NegativeDefaultedCtorOutOfDecl(const NegativeDefaultedCtorOutOfDecl &);
int F;
};
NegativeDefaultedCtorOutOfDecl::NegativeDefaultedCtorOutOfDecl(const NegativeDefaultedCtorOutOfDecl &) = default;
struct PositiveDefaultConstructorOutOfDecl {
PositiveDefaultConstructorOutOfDecl();
int F;
// CHECK-FIXES: int F{};
};
PositiveDefaultConstructorOutOfDecl::PositiveDefaultConstructorOutOfDecl() = default;
// CHECK-MESSAGES: :[[@LINE-1]]:1: warning: constructor does not initialize these fields: F