From 35a8a62125ccfa0ef804584738a295ed5c17750f Mon Sep 17 00:00:00 2001 From: Eric Christopher Date: Tue, 28 Apr 2015 18:09:05 +0000 Subject: [PATCH] Add a fixme to resetTargetOptions to explain why it needs to go away. llvm-svn: 236009 --- llvm/lib/Target/TargetMachine.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/llvm/lib/Target/TargetMachine.cpp b/llvm/lib/Target/TargetMachine.cpp index 5807cf7ca326..69900b012c4f 100644 --- a/llvm/lib/Target/TargetMachine.cpp +++ b/llvm/lib/Target/TargetMachine.cpp @@ -54,6 +54,11 @@ TargetMachine::~TargetMachine() { } /// \brief Reset the target options based on the function's attributes. +// FIXME: This function needs to go away for a number of reasons: +// a) global state on the TargetMachine is terrible in general, +// b) there's no default state here to keep, +// c) these target options should be passed only on the function +// and not on the TargetMachine (via TargetOptions) at all. void TargetMachine::resetTargetOptions(const Function &F) const { #define RESET_OPTION(X, Y) \ do { \