[Sema] Fix PR35832 - Ambiguity accessing anonymous struct/union with multiple bases.

Summary:
Currently clang doesn't do qualified lookup when building indirect field decl references. This causes ambiguity when the field is in a base class to which there are multiple valid paths  even though a qualified name is used.

For example:
```
class B {
protected:
 int i;
 union { int j; };
};

class X : public B { };
class Y : public B { };

class Z : public X, public Y {
 int a() { return X::i; } // works
 int b() { return X::j; } // fails
};
```

Reviewers: rsmith, aaron.ballman, rjmccall

Reviewed By: rjmccall

Subscribers: cfe-commits

Differential Revision: https://reviews.llvm.org/D45411

llvm-svn: 329519
This commit is contained in:
Eric Fiselier 2018-04-08 05:50:01 +00:00
parent e099fc1806
commit 35177d0fec
2 changed files with 20 additions and 1 deletions

View File

@ -848,7 +848,7 @@ Sema::BuildAnonymousStructUnionMemberReference(const CXXScopeSpec &SS,
// Build the first member access in the chain with full information.
result =
BuildFieldReferenceExpr(result, baseObjectIsPointer, SourceLocation(),
EmptySS, field, foundDecl, memberNameInfo)
SS, field, foundDecl, memberNameInfo)
.get();
if (!result)
return ExprError();

View File

@ -0,0 +1,19 @@
// RUN: %clang_cc1 -fsyntax-only -verify %s
// expected-no-diagnostics
class B {
public:
int i;
struct { struct { union { int j; }; }; };
};
class X : public B { };
class Y : public B { };
class Z : public X, Y {
public:
int a() { return X::i; }
int b() { return X::j; }
int c() { return this->X::j; }
};