maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[ELF] Remove a redundant identify_magic call. NFC

This commit is contained in:
Fangrui Song 2022-09-04 14:44:58 -07:00
parent ba3d29f871
commit 343e26c3f0
2 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lld/ELF/InputFiles.cpp
View File

@ -451,16 +451,16 @@ ELFFileBase::ELFFileBase(Kind k, MemoryBufferRef mb) : InputFile(k, mb) {
switch (ekind) {
case ELF32LEKind:
init<ELF32LE>();
init<ELF32LE>(k);
break;
case ELF32BEKind:
init<ELF32BE>();
init<ELF32BE>(k);
break;
case ELF64LEKind:
init<ELF64LE>();
init<ELF64LE>(k);
break;
case ELF64BEKind:
init<ELF64BE>();
init<ELF64BE>(k);
break;
default:
llvm_unreachable("getELFKind");
@ -475,7 +475,7 @@ static const Elf_Shdr *findSection(ArrayRef<Elf_Shdr> sections, uint32_t type) {
return nullptr;
}
template <class ELFT> void ELFFileBase::init() {
template <class ELFT> void ELFFileBase::init(InputFile::Kind k) {
using Elf_Shdr = typename ELFT::Shdr;
using Elf_Sym = typename ELFT::Sym;
@ -490,10 +490,8 @@ template <class ELFT> void ELFFileBase::init() {
numELFShdrs = sections.size();
// Find a symbol table.
bool isDSO =
(identify_magic(mb.getBuffer()) == file_magic::elf_shared_object);
const Elf_Shdr *symtabSec =
findSection(sections, isDSO ? SHT_DYNSYM : SHT_SYMTAB);
findSection(sections, k == SharedKind ? SHT_DYNSYM : SHT_SYMTAB);
if (!symtabSec)
return;

2
lld/ELF/InputFiles.h
View File

@ -196,7 +196,7 @@ public:
protected:
// Initializes this class's member variables.
template <typename ELFT> void init();
template <typename ELFT> void init(InputFile::Kind k);
StringRef stringTable;
const void *elfShdrs = nullptr;