maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

More graceful failure when verifying llvm.noalias. 

PiperOrigin-RevId: 237081778
This commit is contained in:
Dimitrios Vytiniotis 2019-03-06 11:05:43 -08:00 committed by jpienaar
parent 1d87b62afe
commit 32943f5783
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
mlir/lib/LLVMIR/IR/LLVMDialect.cpp
View File

@ -96,8 +96,9 @@ bool LLVMDialect::verifyFunctionArgAttribute(const Function *func,
unsigned argIdx, unsigned argIdx,
NamedAttribute argAttr) { NamedAttribute argAttr) {
// Check that llvm.noalias is a boolean attribute. // Check that llvm.noalias is a boolean attribute.
if (argAttr.first == StringRef("llvm.noalias")) if (argAttr.first == "llvm.noalias" && !argAttr.second.isa<BoolAttr>())
return (!argAttr.second.isa<BoolAttr>()); return func->emitError(
"llvm.noalias argument attribute of non boolean type");
return false; return false;
} }

6
mlir/test/LLVMIR/invalid.mlir Normal file
View File

@ -0,0 +1,6 @@
// RUN: mlir-opt %s -verify
// expected-error@+1{{llvm.noalias argument attribute of non boolean type}}
func @invalid_noalias(%arg0: !llvm<"i32"> {llvm.noalias: 3}) {
"llvm.return"() : () -> ()
}