maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[clang] Remove redundant calls to c_str() (NFC) 

Identified with readability-redundant-string-cstr.
This commit is contained in:
Kazu Hirata 2021-12-26 13:31:40 -08:00
parent 10316a6f94
commit 31cfb3f4f6
3 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clang/lib/CodeGen/CGOpenMPRuntime.cpp
View File

@ -9551,7 +9551,7 @@ emitMappingInformation(CodeGenFunction &CGF, llvm::OpenMPIRBuilder &OMPBuilder,
}
PresumedLoc PLoc = CGF.getContext().getSourceManager().getPresumedLoc(Loc);
return OMPBuilder.getOrCreateSrcLocStr(PLoc.getFilename(), ExprName.c_str(),
return OMPBuilder.getOrCreateSrcLocStr(PLoc.getFilename(), ExprName,
PLoc.getLine(), PLoc.getColumn());
}

16
clang/lib/Driver/ToolChains/CommonArgs.cpp
View File

@ -1724,7 +1724,7 @@ bool tools::GetSDLFromOffloadArchive(
std::string OutputLib = D.GetTemporaryPath(
Twine(Prefix + Lib + "-" + Arch + "-" + Target).str(), "a");
C.addTempFile(C.getArgs().MakeArgString(OutputLib.c_str()));
C.addTempFile(C.getArgs().MakeArgString(OutputLib));
ArgStringList CmdArgs;
SmallString<128> DeviceTriple;
@ -1747,20 +1747,20 @@ bool tools::GetSDLFromOffloadArchive(
T.getToolChain().GetProgramPath("clang-offload-bundler"));
ArgStringList UBArgs;
UBArgs.push_back(C.getArgs().MakeArgString(UnbundleArg.c_str()));
UBArgs.push_back(C.getArgs().MakeArgString(TypeArg.c_str()));
UBArgs.push_back(C.getArgs().MakeArgString(InputArg.c_str()));
UBArgs.push_back(C.getArgs().MakeArgString(OffloadArg.c_str()));
UBArgs.push_back(C.getArgs().MakeArgString(OutputArg.c_str()));
UBArgs.push_back(C.getArgs().MakeArgString(UnbundleArg));
UBArgs.push_back(C.getArgs().MakeArgString(TypeArg));
UBArgs.push_back(C.getArgs().MakeArgString(InputArg));
UBArgs.push_back(C.getArgs().MakeArgString(OffloadArg));
UBArgs.push_back(C.getArgs().MakeArgString(OutputArg));
// Add this flag to not exit from clang-offload-bundler if no compatible
// code object is found in heterogenous archive library.
std::string AdditionalArgs("-allow-missing-bundles");
UBArgs.push_back(C.getArgs().MakeArgString(AdditionalArgs.c_str()));
UBArgs.push_back(C.getArgs().MakeArgString(AdditionalArgs));
C.addCommand(std::make_unique<Command>(
JA, T, ResponseFileSupport::AtFileCurCP(), UBProgram, UBArgs, Inputs,
InputInfo(&JA, C.getArgs().MakeArgString(OutputLib.c_str()))));
InputInfo(&JA, C.getArgs().MakeArgString(OutputLib))));
if (postClangLink)
CC1Args.push_back("-mlink-builtin-bitcode");

2
clang/tools/clang-nvlink-wrapper/ClangNvlinkWrapper.cpp
View File

@ -63,7 +63,7 @@ static Error runNVLink(std::string NVLinkPath,
NVLArgs.push_back(Arg);
}
if (sys::ExecuteAndWait(NVLinkPath.c_str(), NVLArgs))
if (sys::ExecuteAndWait(NVLinkPath, NVLArgs))
return createStringError(inconvertibleErrorCode(), "'nvlink' failed");
return Error::success();
}