maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[lldb] Explicitly qualify calls to std::static_pointer_cast 

Due to a c++ quirk, these are found through ADL only when a function with that
name is found through regular lookup. We have one such function in SharingPtr.h,
but I am trying to remove it.
This commit is contained in:
Pavel Labath 2020-02-06 10:53:34 -08:00
parent 17d0091d66
commit 31cf581998
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lldb/include/lldb/Interpreter/CommandReturnObject.h
View File

@ -30,14 +30,14 @@ public:
llvm::StringRef GetOutputData() { llvm::StringRef GetOutputData() {
lldb::StreamSP stream_sp(m_out_stream.GetStreamAtIndex(eStreamStringIndex)); lldb::StreamSP stream_sp(m_out_stream.GetStreamAtIndex(eStreamStringIndex));
if (stream_sp) if (stream_sp)
return static_pointer_cast<StreamString>(stream_sp)->GetString(); return std::static_pointer_cast<StreamString>(stream_sp)->GetString();
return llvm::StringRef(); return llvm::StringRef();
} }
llvm::StringRef GetErrorData() { llvm::StringRef GetErrorData() {
lldb::StreamSP stream_sp(m_err_stream.GetStreamAtIndex(eStreamStringIndex)); lldb::StreamSP stream_sp(m_err_stream.GetStreamAtIndex(eStreamStringIndex));
if (stream_sp) if (stream_sp)
return static_pointer_cast<StreamString>(stream_sp)->GetString(); return std::static_pointer_cast<StreamString>(stream_sp)->GetString();
return llvm::StringRef(); return llvm::StringRef();
} }

2
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
View File

@ -3479,7 +3479,7 @@ GDBRemoteCommunicationClient::SendGetTraceConfigPacket(lldb::user_id_t uid,
return error; return error;
} else } else
options.setTraceParams( options.setTraceParams(
static_pointer_cast<StructuredData::Dictionary>( std::static_pointer_cast<StructuredData::Dictionary>(
custom_params_sp)); custom_params_sp));
} }
} else { } else {

2
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
View File

@ -1072,7 +1072,7 @@ GDBRemoteCommunicationServerLLGS::Handle_jTraceStart(
return SendIllFormedResponse(packet, "jTraceStart: Ill formed packet "); return SendIllFormedResponse(packet, "jTraceStart: Ill formed packet ");
options.setTraceParams( options.setTraceParams(
static_pointer_cast<StructuredData::Dictionary>(custom_params_sp)); std::static_pointer_cast<StructuredData::Dictionary>(custom_params_sp));
if (buffersize == std::numeric_limits<uint64_t>::max() || if (buffersize == std::numeric_limits<uint64_t>::max() ||
type != lldb::TraceType::eTraceTypeProcessorTrace) { type != lldb::TraceType::eTraceTypeProcessorTrace) {