maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Cleanup checks in the load and store of casted pointer transforms. Two 

changes: (1) don't special case for i1 any more, (2) use the new
TargetData::getTypeSizeInBits method to ensure source and dest are the
same bit width.

llvm-svn: 33427
This commit is contained in:
Reid Spencer 2007-01-22 05:51:25 +00:00
parent e977757ca9
commit 31a4ef4dc1
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
llvm/lib/Transforms/Scalar/InstructionCombining.cpp
View File

@ -7990,8 +7990,8 @@ static Instruction *InstCombineLoadCast(InstCombiner &IC, LoadInst &LI) {
if (const PointerType *SrcTy = dyn_cast<PointerType>(CastOp->getType())) { if (const PointerType *SrcTy = dyn_cast<PointerType>(CastOp->getType())) {
const Type *SrcPTy = SrcTy->getElementType(); const Type *SrcPTy = SrcTy->getElementType();
if ((DestPTy->isInteger() && DestPTy != Type::Int1Ty) || if (DestPTy->isInteger() || isa<PointerType>(DestPTy) ||
isa<PointerType>(DestPTy) || isa<PackedType>(DestPTy)) { isa<PackedType>(DestPTy)) {
// If the source is an array, the code below will not succeed. Check to // If the source is an array, the code below will not succeed. Check to
// see if a trivial 'gep P, 0, 0' will help matters. Only do this for // see if a trivial 'gep P, 0, 0' will help matters. Only do this for
// constants. // constants.
@ -8004,13 +8004,13 @@ static Instruction *InstCombineLoadCast(InstCombiner &IC, LoadInst &LI) {
SrcPTy = SrcTy->getElementType(); SrcPTy = SrcTy->getElementType();
} }
if (((SrcPTy->isInteger() && SrcPTy != Type::Int1Ty) || if ((SrcPTy->isInteger() || isa<PointerType>(SrcPTy) ||
isa<PointerType>(SrcPTy) || isa<PackedType>(SrcPTy)) && isa<PackedType>(SrcPTy)) &&
// Do not allow turning this into a load of an integer, which is then // Do not allow turning this into a load of an integer, which is then
// casted to a pointer, this pessimizes pointer analysis a lot. // casted to a pointer, this pessimizes pointer analysis a lot.
(isa<PointerType>(SrcPTy) == isa<PointerType>(LI.getType())) && (isa<PointerType>(SrcPTy) == isa<PointerType>(LI.getType())) &&
IC.getTargetData().getTypeSize(SrcPTy) == IC.getTargetData().getTypeSizeInBits(SrcPTy) ==
IC.getTargetData().getTypeSize(DestPTy)) { IC.getTargetData().getTypeSizeInBits(DestPTy)) {
// Okay, we are casting from one integer or pointer type to another of // Okay, we are casting from one integer or pointer type to another of
// the same size. Instead of casting the pointer before the load, cast // the same size. Instead of casting the pointer before the load, cast
@ -8178,8 +8178,7 @@ static Instruction *InstCombineStoreToCast(InstCombiner &IC, StoreInst &SI) {
if (const PointerType *SrcTy = dyn_cast<PointerType>(CastOp->getType())) { if (const PointerType *SrcTy = dyn_cast<PointerType>(CastOp->getType())) {
const Type *SrcPTy = SrcTy->getElementType(); const Type *SrcPTy = SrcTy->getElementType();
if ((DestPTy->isInteger() && DestPTy != Type::Int1Ty) || if (DestPTy->isInteger() || isa<PointerType>(DestPTy)) {
isa<PointerType>(DestPTy)) {
// If the source is an array, the code below will not succeed. Check to // If the source is an array, the code below will not succeed. Check to
// see if a trivial 'gep P, 0, 0' will help matters. Only do this for // see if a trivial 'gep P, 0, 0' will help matters. Only do this for
// constants. // constants.