maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[llvm-symbolizer] Remove one-dash long options 

Most modern tools only accept two-dash long options. Remove one-dash
long options which are not recognized by GNU style `getopt_long`.
This ensures long options cannot collide with grouped short options.

Note: llvm-symbolizer has `-demangle={true,false}` for pprof compatibility
(for a while). They are kept.

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D106377
This commit is contained in:
Fangrui Song 2021-07-23 08:35:45 -07:00
parent 2c508cf583
commit 31677c6481
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
llvm/test/tools/llvm-symbolizer/pdb/missing_pdb.test
View File

@ -1,4 +1,4 @@
RUN: llvm-symbolizer 0x401000 0x401001 -obj="%p/Inputs/missing_pdb.exe" 2>%t.err \
RUN: llvm-symbolizer 0x401000 0x401001 --obj="%p/Inputs/missing_pdb.exe" 2>%t.err \
RUN: | FileCheck %s
RUN: FileCheck -DMSG=%errc_ENOENT --check-prefix=ERROR %s < %t.err

2
llvm/test/tools/llvm-symbolizer/pdb/pdb-columns.test
View File

@ -6,7 +6,7 @@ RUN: echo 0x140006C20 >> %t.input
RUN: echo 0x140006C30 >> %t.input
RUN: echo 0x140006C40 >> %t.input
RUN: echo 0x140006C70 >> %t.input
RUN: llvm-symbolizer -obj="%p/Inputs/test-columns.exe" < %t.input \
RUN: llvm-symbolizer --obj="%p/Inputs/test-columns.exe" < %t.input \
RUN: | FileCheck %s
This tests that the symbolizer outputs column info when it is present in the pdb.

10
llvm/tools/llvm-symbolizer/Opts.td
View File

@ -1,17 +1,17 @@
include "llvm/Option/OptParser.td"
multiclass B<string name, string help1, string help2> {
def NAME: Flag<["--", "-"], name>, HelpText<help1>;
def no_ # NAME: Flag<["--", "-"], "no-" # name>, HelpText<help2>;
def NAME: Flag<["--"], name>, HelpText<help1>;
def no_ # NAME: Flag<["--"], "no-" # name>, HelpText<help2>;
}
multiclass Eq<string name, string help> {
def NAME #_EQ : Joined<["--", "-"], name #"=">,
def NAME #_EQ : Joined<["--"], name #"=">,
HelpText<help>;
def : Separate<["--", "-"], name>, Alias<!cast<Joined>(NAME #_EQ)>;
def : Separate<["--"], name>, Alias<!cast<Joined>(NAME #_EQ)>;
}
class F<string name, string help>: Flag<["--", "-"], name>, HelpText<help>;
class F<string name, string help>: Flag<["--"], name>, HelpText<help>;
def grp_mach_o : OptionGroup<"kind">,
HelpText<"llvm-symbolizer Mach-O Specific Options">;