maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Remove code that pad number of bytes to pop for X86_FastCall CC. The code doesn't do the "aligning" for Cygwin, Mingw, and Windows. But aligning it on Darwin and Linux breaks gcc compatibility. That ruled out all the platforms we support! 

llvm-svn: 55756
This commit is contained in:
Evan Cheng 2008-09-04 01:04:15 +00:00
parent da2d80688b
commit 3152edf474
2 changed files with 1 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
llvm/lib/Target/X86/X86ISelLowering.cpp
View File

@ -1379,14 +1379,6 @@ X86TargetLowering::LowerFORMAL_ARGUMENTS(SDValue Op, SelectionDAG &DAG) {
}
}
// Make sure the instruction takes 8n+4 bytes to make sure the start of the
// arguments and the arguments after the retaddr has been pushed are
// aligned.
if (!Is64Bit && CC == CallingConv::X86_FastCall &&
!Subtarget->isTargetCygMing() && !Subtarget->isTargetWindows() &&
(StackSize & 7) == 0)
StackSize += 4;
ArgValues.push_back(Root);
// Some CCs need callee pop.
@ -1494,13 +1486,6 @@ SDValue X86TargetLowering::LowerCALL(SDValue Op, SelectionDAG &DAG) {
if (CC == CallingConv::Fast)
NumBytes = GetAlignedArgumentStackSize(NumBytes, DAG);
// Make sure the instruction takes 8n+4 bytes to make sure the start of the
// arguments and the arguments after the retaddr has been pushed are aligned.
if (!Is64Bit && CC == CallingConv::X86_FastCall &&
!Subtarget->isTargetCygMing() && !Subtarget->isTargetWindows() &&
(NumBytes & 7) == 0)
NumBytes += 4;
int FPDiff = 0;
if (IsTailCall) {
// Lower arguments at fp - stackoffset + fpdiff.

2
llvm/test/CodeGen/X86/fast-cc-callee-pops.ll
View File

@ -3,6 +3,6 @@
; Check that a fastcc function pops its stack variables before returning.
define x86_fastcallcc void @func(i64 %X, i64 %Y, float %G, double %Z) {
define x86_fastcallcc void @func(i64 %X, i64 %Y, float %G, double %Z) nounwind {
ret void
}