maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[libc++] Do not force building with -fPIC (re-applying) 

Summary:
In r355746, we stopped forcing to build with -fPIC because that should
be specified by the CMAKE_POSITION_INDEPENDENT_CODE option at CMake
configure time (and by default -fPIC is used for shared libraries anyways).

However, r355746 had to be reverted in r355756 because we were not
actually building the shared library with -fPIC. The reason is that
we were sharing an object library between the static and the shared
library, which caused flags for static libraries to be used when
building object files that were going to be used for a shared library.

Since this was resolved by r356150, we can stop forcing -fPIC again.

Reviewers: EricWF, smeenai

Subscribers: mgorny, christof, jkorous, dexonsmith, libcxx-commits

Differential Revision: https://reviews.llvm.org/D59250

llvm-svn: 356153
This commit is contained in:
Louis Dionne 2019-03-14 14:38:38 +00:00
parent f5fe2974cf
commit 30f305efe2
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libcxx/lib/CMakeLists.txt
View File

@ -105,10 +105,6 @@ if (LIBCXXABI_USE_LLVM_UNWINDER)
endif()
# Setup flags.
if (NOT WIN32)
add_flags_if_supported(-fPIC)
endif()
add_link_flags_if_supported(-nodefaultlibs)
if (LIBCXX_TARGETING_MSVC)