If the user has specified target.memory-module-load-level 'minimal'

and we couldn't find a dyld binary on the debug system, override
that setting and read dyld out of memory - we need to put an
internal breakpoint on dyld to register binaries being loaded or
unloaded; the debugger won't work right without dyld symbols.

<rdar://problem/27857025> 

llvm-svn: 279704
This commit is contained in:
Jason Molenda 2016-08-25 02:33:09 +00:00
parent b42e0e7fa3
commit 30c18ecb3d
1 changed files with 5 additions and 3 deletions

View File

@ -2454,7 +2454,10 @@ ObjectFileMachO::ParseSymtab ()
if (!data_was_read)
{
if (memory_module_load_level == eMemoryModuleLoadLevelComplete)
// Always load dyld - the dynamic linker - from memory if we didn't find a binary anywhere else.
// lldb will not register dylib/framework/bundle loads/unloads if we don't have the dyld symbols,
// we force dyld to load from memory despite the user's target.memory-module-load-level setting.
if (memory_module_load_level == eMemoryModuleLoadLevelComplete || m_header.filetype == llvm::MachO::MH_DYLINKER)
{
DataBufferSP nlist_data_sp (ReadMemory (process_sp, symoff_addr, nlist_data_byte_size));
if (nlist_data_sp)
@ -2472,8 +2475,7 @@ ObjectFileMachO::ParseSymtab ()
indirect_symbol_index_data.SetData (indirect_syms_data_sp, 0, indirect_syms_data_sp->GetByteSize());
}
}
if (memory_module_load_level >= eMemoryModuleLoadLevelPartial)
else if (memory_module_load_level >= eMemoryModuleLoadLevelPartial)
{
if (function_starts_load_command.cmd)
{