From 3064620d0d5bd14ec7faf1bec0ec49f650981e85 Mon Sep 17 00:00:00 2001 From: Daniel Jasper Date: Mon, 14 Jul 2014 12:38:38 +0000 Subject: [PATCH] clang-format: Improve cast detection (fix false positive). Before: fn(a)(b)+1; After: fn(a)(b) + 1; llvm-svn: 212935 --- clang/lib/Format/TokenAnnotator.cpp | 2 ++ clang/unittests/Format/FormatTest.cpp | 1 + 2 files changed, 3 insertions(+) diff --git a/clang/lib/Format/TokenAnnotator.cpp b/clang/lib/Format/TokenAnnotator.cpp index afa9840619ef..c150c91e96ad 100644 --- a/clang/lib/Format/TokenAnnotator.cpp +++ b/clang/lib/Format/TokenAnnotator.cpp @@ -841,6 +841,8 @@ private: FormatToken *LeftOfParens = nullptr; if (Tok.MatchingParen) LeftOfParens = Tok.MatchingParen->getPreviousNonComment(); + if (LeftOfParens && LeftOfParens->is(tok::r_paren)) + return false; bool IsCast = false; bool ParensAreEmpty = Tok.Previous == Tok.MatchingParen; bool ParensAreType = !Tok.Previous || diff --git a/clang/unittests/Format/FormatTest.cpp b/clang/unittests/Format/FormatTest.cpp index 16959690e008..81b233c2f549 100644 --- a/clang/unittests/Format/FormatTest.cpp +++ b/clang/unittests/Format/FormatTest.cpp @@ -4975,6 +4975,7 @@ TEST_F(FormatTest, FormatsCasts) { verifyFormat("return (my_int)aaa;"); verifyFormat("#define x ((int)-1)"); verifyFormat("#define p(q) ((int *)&q)"); + verifyFormat("fn(a)(b) + 1;"); verifyFormat("void f() { my_int a = (my_int)*b; }"); verifyFormat("void f() { return P ? (my_int)*P : (my_int)0; }");