maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[SDAG] Remove a giant pile of asserts that may have helped track down 

a bug in 2010 when they were added but are adding no value today.

In fact, they are utter lies. NodeAllocator is used to allocate almost
all of these node types. I don't know what we were trying to assert
here, and the docs don't give any answer. Until we once again stumble
upon a bug needing help, let's clear the path for improvements.

llvm-svn: 213610
This commit is contained in:
Chandler Carruth 2014-07-22 04:03:22 +00:00
parent 965cfa1d5b
commit 2fc9a2b8eb
1 changed files with 3 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
View File

@ -840,8 +840,8 @@ SDNode *SelectionDAG::FindModifiedNodeSlot(SDNode *N, ArrayRef<SDValue> Ops,
} }
#ifndef NDEBUG #ifndef NDEBUG
/// VerifyNodeCommon - Sanity check the given node. Aborts if it is invalid. /// VerifySDNode - Sanity check the given SDNode. Aborts if it is invalid.
static void VerifyNodeCommon(SDNode *N) { static void VerifySDNode(SDNode *N) {
switch (N->getOpcode()) { switch (N->getOpcode()) {
default: default:
break; break;
@ -877,43 +877,6 @@ static void VerifyNodeCommon(SDNode *N) {
} }
} }
} }
/// VerifySDNode - Sanity check the given SDNode. Aborts if it is invalid.
static void VerifySDNode(SDNode *N) {
// The SDNode allocators cannot be used to allocate nodes with fields that are
// not present in an SDNode!
assert(!isa<MemSDNode>(N) && "Bad MemSDNode!");
assert(!isa<ShuffleVectorSDNode>(N) && "Bad ShuffleVectorSDNode!");
assert(!isa<ConstantSDNode>(N) && "Bad ConstantSDNode!");
assert(!isa<ConstantFPSDNode>(N) && "Bad ConstantFPSDNode!");
assert(!isa<GlobalAddressSDNode>(N) && "Bad GlobalAddressSDNode!");
assert(!isa<FrameIndexSDNode>(N) && "Bad FrameIndexSDNode!");
assert(!isa<JumpTableSDNode>(N) && "Bad JumpTableSDNode!");
assert(!isa<ConstantPoolSDNode>(N) && "Bad ConstantPoolSDNode!");
assert(!isa<BasicBlockSDNode>(N) && "Bad BasicBlockSDNode!");
assert(!isa<SrcValueSDNode>(N) && "Bad SrcValueSDNode!");
assert(!isa<MDNodeSDNode>(N) && "Bad MDNodeSDNode!");
assert(!isa<RegisterSDNode>(N) && "Bad RegisterSDNode!");
assert(!isa<BlockAddressSDNode>(N) && "Bad BlockAddressSDNode!");
assert(!isa<EHLabelSDNode>(N) && "Bad EHLabelSDNode!");
assert(!isa<ExternalSymbolSDNode>(N) && "Bad ExternalSymbolSDNode!");
assert(!isa<CondCodeSDNode>(N) && "Bad CondCodeSDNode!");
assert(!isa<CvtRndSatSDNode>(N) && "Bad CvtRndSatSDNode!");
assert(!isa<VTSDNode>(N) && "Bad VTSDNode!");
assert(!isa<MachineSDNode>(N) && "Bad MachineSDNode!");
VerifyNodeCommon(N);
}
/// VerifyMachineNode - Sanity check the given MachineNode. Aborts if it is
/// invalid.
static void VerifyMachineNode(SDNode *N) {
// The MachineNode allocators cannot be used to allocate nodes with fields
// that are not present in a MachineNode!
// Currently there are no such nodes.
VerifyNodeCommon(N);
}
#endif // NDEBUG #endif // NDEBUG
/// getEVTAlignment - Compute the default alignment value for the /// getEVTAlignment - Compute the default alignment value for the
@ -5751,7 +5714,7 @@ SelectionDAG::getMachineNode(unsigned Opcode, SDLoc DL, SDVTList VTs,
AllNodes.push_back(N); AllNodes.push_back(N);
#ifndef NDEBUG #ifndef NDEBUG
VerifyMachineNode(N); VerifySDNode(N);
#endif #endif
return N; return N;
} }