maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

checkDLLAttribute: remove a redundant dyn_cast 

The same dyn_cast was done earlier in the function. No functionality change.

llvm-svn: 216326
This commit is contained in:
Hans Wennborg 2014-08-23 21:10:39 +00:00
parent ad7c910ecf
commit 2f9e293e37
1 changed files with 19 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
clang/lib/Sema/SemaDeclCXX.cpp
View File

@ -4471,29 +4471,27 @@ static void checkDLLAttribute(Sema &S, CXXRecordDecl *Class) {
Member->addAttr(NewAttr);
}
if (CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(Member)) {
if (ClassExported) {
if (MD->isUserProvided()) {
// Instantiate non-default methods..
if (MD && ClassExported) {
if (MD->isUserProvided()) {
// Instantiate non-default methods..
// .. except for certain kinds of template specializations.
if (TSK == TSK_ExplicitInstantiationDeclaration)
continue;
if (TSK == TSK_ImplicitInstantiation && !ClassAttr->isInherited())
continue;
// .. except for certain kinds of template specializations.
if (TSK == TSK_ExplicitInstantiationDeclaration)
continue;
if (TSK == TSK_ImplicitInstantiation && !ClassAttr->isInherited())
continue;
S.MarkFunctionReferenced(Class->getLocation(), MD);
} else if (!MD->isTrivial() || MD->isExplicitlyDefaulted() ||
MD->isCopyAssignmentOperator() ||
MD->isMoveAssignmentOperator()) {
// Instantiate non-trivial or explicitly defaulted methods, and the
// copy assignment / move assignment operators.
S.MarkFunctionReferenced(Class->getLocation(), MD);
// Resolve its exception specification; CodeGen needs it.
auto *FPT = MD->getType()->getAs<FunctionProtoType>();
S.ResolveExceptionSpec(Class->getLocation(), FPT);
S.ActOnFinishInlineMethodDef(MD);
}
S.MarkFunctionReferenced(Class->getLocation(), MD);
} else if (!MD->isTrivial() || MD->isExplicitlyDefaulted() ||
MD->isCopyAssignmentOperator() ||
MD->isMoveAssignmentOperator()) {
// Instantiate non-trivial or explicitly defaulted methods, and the
// copy assignment / move assignment operators.
S.MarkFunctionReferenced(Class->getLocation(), MD);
// Resolve its exception specification; CodeGen needs it.
auto *FPT = MD->getType()->getAs<FunctionProtoType>();
S.ResolveExceptionSpec(Class->getLocation(), FPT);
S.ActOnFinishInlineMethodDef(MD);
}
}
}