maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

clang-tidy - silence static analyzer getAs<> null dereference warnings. NFCI. 

The static analyzer is warning about potential null dereferences, but in these cases we should be able to use castAs<> directly and if not assert will fire for us.

llvm-svn: 375102
This commit is contained in:
Simon Pilgrim 2019-10-17 11:12:53 +00:00
parent e14851259e
commit 2ea8b58cb6
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp
View File

@ -478,7 +478,7 @@ canOverloadedOperatorArgsBeModified(const FunctionDecl *OperatorDecl,
// These functions must be declared const in order to not be able to modify
// the instance of the class they are called through.
if (ParamCount == 1 &&
!OperatorDecl->getType()->getAs<FunctionType>()->isConst())
!OperatorDecl->getType()->castAs<FunctionType>()->isConst())
return true;
if (isNonConstReferenceType(OperatorDecl->getParamDecl(0)->getType()))

8
clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
View File

@ -29,7 +29,7 @@ static StringRef getValueOfValueInit(const QualType InitType) {
return "false";
case Type::STK_Integral:
switch (InitType->getAs<BuiltinType>()->getKind()) {
switch (InitType->castAs<BuiltinType>()->getKind()) {
case BuiltinType::Char_U:
case BuiltinType::UChar:
case BuiltinType::Char_S:
@ -47,7 +47,7 @@ static StringRef getValueOfValueInit(const QualType InitType) {
}
case Type::STK_Floating:
switch (InitType->getAs<BuiltinType>()->getKind()) {
switch (InitType->castAs<BuiltinType>()->getKind()) {
case BuiltinType::Half:
case BuiltinType::Float:
return "0.0f";
@ -58,10 +58,10 @@ static StringRef getValueOfValueInit(const QualType InitType) {
case Type::STK_FloatingComplex:
case Type::STK_IntegralComplex:
return getValueOfValueInit(
InitType->getAs<ComplexType>()->getElementType());
InitType->castAs<ComplexType>()->getElementType());
case Type::STK_FixedPoint:
switch (InitType->getAs<BuiltinType>()->getKind()) {
switch (InitType->castAs<BuiltinType>()->getKind()) {
case BuiltinType::ShortAccum:
case BuiltinType::SatShortAccum:
return "0.0hk";