maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[lldb-vscod] fix build with NDEBUG on windows 

Summary: _setmode in assert will not run when build with NDEBUG

Reviewers: mstorsjo, labath, amccarth

Reviewed By: labath

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D69612
This commit is contained in:
SquallATF 2019-10-30 14:20:21 +01:00 committed by Pavel Labath
parent f1e0ae3420
commit 2dbcfad35d
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lldb/tools/lldb-vscode/VSCode.cpp
View File

@ -44,8 +44,10 @@ VSCode::VSCode()
// Windows opens stdout and stdin in text mode which converts \n to 13,10
// while the value is just 10 on Darwin/Linux. Setting the file mode to binary
// fixes this.
assert(_setmode(fileno(stdout), _O_BINARY));
assert(_setmode(fileno(stdin), _O_BINARY));
int result = _setmode(fileno(stdout), _O_BINARY);
assert(result);
result = _setmode(fileno(stdin), _O_BINARY);
assert(result);
#endif
if (log_file_path)
log.reset(new std::ofstream(log_file_path));
@ -301,4 +303,3 @@ void VSCode::RunExitCommands() {
}
} // namespace lldb_vscode