maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[Attributor][NFC] Eagerly mark attributes as fixed. 

If an attribute did not query any optimistic (=non-fixed) information to
justify its state, we know the attribute state will not change anymore.
Thus, we can indicate an optimistic fixpoint.
This commit is contained in:
Johannes Doerfert 2019-10-13 21:10:31 -05:00
parent 12173e60ec
commit 2dad729f0c
2 changed files with 17 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
llvm/include/llvm/Transforms/IPO/Attributor.h
View File

@ -959,6 +959,9 @@ private:
/// The information cache that holds pre-processed (LLVM-IR) information.
InformationCache &InfoCache;
/// Set if the attribute currently updated did query a non-fix attribute.
bool QueriedNonFixAA;
/// Number of iterations until the dependences between abstract attributes are
/// recomputed.
const unsigned DepRecomputeInterval;

18
llvm/lib/Transforms/IPO/Attributor.cpp
View File

@ -4496,9 +4496,16 @@ ChangeStatus Attributor::run(Module &M) {
// Update all abstract attribute in the work list and record the ones that
// changed.
for (AbstractAttribute *AA : Worklist)
if (!isAssumedDead(*AA, nullptr))
if (AA->update(*this) == ChangeStatus::CHANGED)
if (!AA->getState().isAtFixpoint() && !isAssumedDead(*AA, nullptr)) {
QueriedNonFixAA = false;
if (AA->update(*this) == ChangeStatus::CHANGED) {
ChangedAAs.push_back(AA);
} else if (!QueriedNonFixAA) {
// If the attribute did not query any non-fix information, the state
// will not change and we can indicate that right away.
AA->getState().indicateOptimisticFixpoint();
}
}
// Check if we recompute the dependences in the next iteration.
RecomputeDependences = (DepRecomputeInterval > 0 &&
@ -4713,8 +4720,11 @@ void Attributor::initializeInformationCache(Function &F) {
void Attributor::recordDependence(const AbstractAttribute &FromAA,
const AbstractAttribute &ToAA) {
if (!FromAA.getState().isAtFixpoint())
QueryMap[&FromAA].insert(const_cast<AbstractAttribute *>(&ToAA));
if (FromAA.getState().isAtFixpoint())
return;
QueryMap[&FromAA].insert(const_cast<AbstractAttribute *>(&ToAA));
QueriedNonFixAA = true;
}
void Attributor::identifyDefaultAbstractAttributes(Function &F) {