From 2da15e4dc8f9c82a1098385251b7e8d2ad0c9cda Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Fri, 28 Dec 2018 13:34:50 +0000 Subject: [PATCH] Fix signed-unsigned comparisons in MinidumpParserTest llvm-svn: 350122 --- lldb/unittests/Process/minidump/MinidumpParserTest.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lldb/unittests/Process/minidump/MinidumpParserTest.cpp b/lldb/unittests/Process/minidump/MinidumpParserTest.cpp index 610d3df8ef03..92ea20f72860 100644 --- a/lldb/unittests/Process/minidump/MinidumpParserTest.cpp +++ b/lldb/unittests/Process/minidump/MinidumpParserTest.cpp @@ -636,8 +636,8 @@ TEST_F(MinidumpParserTest, MinidumpDuplicateModuleMinAddress) { // one time, we pick the one with the lowest base_of_image. std::vector filtered_modules = parser->GetFilteredModuleList(); - EXPECT_EQ(1, filtered_modules.size()); - EXPECT_EQ(0x0000000000001000, filtered_modules[0]->base_of_image); + EXPECT_EQ(1u, filtered_modules.size()); + EXPECT_EQ(0x0000000000001000u, filtered_modules[0]->base_of_image); } TEST_F(MinidumpParserTest, MinidumpModuleOrder) { @@ -652,12 +652,12 @@ TEST_F(MinidumpParserTest, MinidumpModuleOrder) { std::vector filtered_modules = parser->GetFilteredModuleList(); llvm::Optional name; - EXPECT_EQ(2, filtered_modules.size()); - EXPECT_EQ(0x0000000000002000, filtered_modules[0]->base_of_image); + EXPECT_EQ(2u, filtered_modules.size()); + EXPECT_EQ(0x0000000000002000u, filtered_modules[0]->base_of_image); name = parser->GetMinidumpString(filtered_modules[0]->module_name_rva); ASSERT_TRUE((bool)name); EXPECT_EQ(std::string("/tmp/a"), *name); - EXPECT_EQ(0x0000000000001000, filtered_modules[1]->base_of_image); + EXPECT_EQ(0x0000000000001000u, filtered_modules[1]->base_of_image); name = parser->GetMinidumpString(filtered_modules[1]->module_name_rva); ASSERT_TRUE((bool)name); EXPECT_EQ(std::string("/tmp/b"), *name);