maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Fix signed-unsigned comparisons in MinidumpParserTest 

llvm-svn: 350122
This commit is contained in:
Pavel Labath 2018-12-28 13:34:50 +00:00
parent ffec31e462
commit 2da15e4dc8
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lldb/unittests/Process/minidump/MinidumpParserTest.cpp
View File

@ -636,8 +636,8 @@ TEST_F(MinidumpParserTest, MinidumpDuplicateModuleMinAddress) {
// one time, we pick the one with the lowest base_of_image.
std::vector<const MinidumpModule *> filtered_modules =
parser->GetFilteredModuleList();
EXPECT_EQ(1, filtered_modules.size());
EXPECT_EQ(0x0000000000001000, filtered_modules[0]->base_of_image);
EXPECT_EQ(1u, filtered_modules.size());
EXPECT_EQ(0x0000000000001000u, filtered_modules[0]->base_of_image);
}
TEST_F(MinidumpParserTest, MinidumpModuleOrder) {
@ -652,12 +652,12 @@ TEST_F(MinidumpParserTest, MinidumpModuleOrder) {
std::vector<const MinidumpModule *> filtered_modules =
parser->GetFilteredModuleList();
llvm::Optional<std::string> name;
EXPECT_EQ(2, filtered_modules.size());
EXPECT_EQ(0x0000000000002000, filtered_modules[0]->base_of_image);
EXPECT_EQ(2u, filtered_modules.size());
EXPECT_EQ(0x0000000000002000u, filtered_modules[0]->base_of_image);
name = parser->GetMinidumpString(filtered_modules[0]->module_name_rva);
ASSERT_TRUE((bool)name);
EXPECT_EQ(std::string("/tmp/a"), *name);
EXPECT_EQ(0x0000000000001000, filtered_modules[1]->base_of_image);
EXPECT_EQ(0x0000000000001000u, filtered_modules[1]->base_of_image);
name = parser->GetMinidumpString(filtered_modules[1]->module_name_rva);
ASSERT_TRUE((bool)name);
EXPECT_EQ(std::string("/tmp/b"), *name);