maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

While testing dragonegg I noticed that isCastable and getCastOpcode 

had gotten out of sync: isCastable didn't think it was possible to
cast the x86_mmx type to anything, while it did think it possible
to cast an i64 to x86_mmx.

llvm-svn: 128705
This commit is contained in:
Duncan Sands 2011-04-01 03:34:54 +00:00
parent 8a05f66139
commit 2d3cdd686b
2 changed files with 25 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
llvm/lib/VMCore/Instructions.cpp
View File

@ -2297,8 +2297,12 @@ bool CastInst::isCastable(const Type *SrcTy, const Type *DestTy) {
if (const VectorType *SrcPTy = dyn_cast<VectorType>(SrcTy)) {
// Casting from vector
return DestPTy->getBitWidth() == SrcPTy->getBitWidth();
} else { // Casting from something else
return DestPTy->getBitWidth() == SrcBits;
} else if (DestPTy->getBitWidth() == SrcBits) {
return true; // float/int -> vector
} else if (SrcTy->isX86_MMXTy()) {
return DestPTy->getBitWidth() == 64; // MMX to 64-bit vector
} else {
return false;
}
} else if (DestTy->isPointerTy()) { // Casting to pointer
if (SrcTy->isPointerTy()) { // Casting from pointer
@ -2309,7 +2313,11 @@ bool CastInst::isCastable(const Type *SrcTy, const Type *DestTy) {
return false;
}
} else if (DestTy->isX86_MMXTy()) {
return SrcBits == 64;
if (const VectorType *SrcPTy = dyn_cast<VectorType>(SrcTy)) {
return SrcPTy->getBitWidth() == 64; // 64-bit vector to MMX
} else {
return false;
}
} else { // Casting to something else
return false;
}

13
llvm/unittests/VMCore/InstructionsTest.cpp
View File

@ -107,5 +107,18 @@ TEST(InstructionsTest, BranchInst) {
delete bb1;
}
TEST(InstructionsTest, CastInst) {
LLVMContext &C(getGlobalContext());
const Type* Int8Ty = Type::getInt8Ty(C);
const Type* Int64Ty = Type::getInt64Ty(C);
const Type* V8x8Ty = VectorType::get(Int8Ty, 8);
const Type* X86MMXTy = Type::getX86_MMXTy(C);
EXPECT_TRUE(CastInst::isCastable(V8x8Ty, X86MMXTy));
EXPECT_TRUE(CastInst::isCastable(X86MMXTy, V8x8Ty));
EXPECT_FALSE(CastInst::isCastable(Int64Ty, X86MMXTy));
}
} // end anonymous namespace
} // end namespace llvm