maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[LazyValueInfo] Avoid unnecessary copies of ConstantRanges 

Summary:
ConstantRange contains two APInts which can allocate memory if their width is larger than 64-bits. So we shouldn't copy it when we can avoid it.

This changes LVILatticeVal::getConstantRange() to return its internal ConstantRange by reference. This allows many places that just need a ConstantRange reference to avoid making a copy.

Several places now capture the return value of getConstantRange() by reference so they can call methods on it that don't need a new object.

Lastly it adds std::move in one place to capture to move a local ConstantRange into an LVILatticeVal.

Reviewers: reames, dberlin, sanjoy, anna

Reviewed By: reames

Subscribers: grandinj, llvm-commits

Differential Revision: https://reviews.llvm.org/D32884

llvm-svn: 302331
This commit is contained in:
Craig Topper 2017-05-06 03:35:15 +00:00
parent 28d89dbd3f
commit 2b195fd2c3
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
llvm/lib/Analysis/LazyValueInfo.cpp
View File

@ -142,7 +142,7 @@ public:
return Val; return Val;
} }
ConstantRange getConstantRange() const { const ConstantRange &getConstantRange() const {
assert(isConstantRange() && assert(isConstantRange() &&
"Cannot get the constant-range of a non-constant-range!"); "Cannot get the constant-range of a non-constant-range!");
return Range; return Range;
@ -250,7 +250,7 @@ public:
if (NewR.isFullSet()) if (NewR.isFullSet())
markOverdefined(); markOverdefined();
else else
markConstantRange(NewR); markConstantRange(std::move(NewR));
} }
}; };
@ -1079,8 +1079,8 @@ bool LazyValueInfoImpl::solveBlockValueSelect(LVILatticeVal &BBLV,
} }
if (TrueVal.isConstantRange() && FalseVal.isConstantRange()) { if (TrueVal.isConstantRange() && FalseVal.isConstantRange()) {
ConstantRange TrueCR = TrueVal.getConstantRange(); const ConstantRange &TrueCR = TrueVal.getConstantRange();
ConstantRange FalseCR = FalseVal.getConstantRange(); const ConstantRange &FalseCR = FalseVal.getConstantRange();
Value *LHS = nullptr; Value *LHS = nullptr;
Value *RHS = nullptr; Value *RHS = nullptr;
SelectPatternResult SPR = matchSelectPattern(SI, LHS, RHS); SelectPatternResult SPR = matchSelectPattern(SI, LHS, RHS);
@ -1649,7 +1649,7 @@ Constant *LazyValueInfo::getConstant(Value *V, BasicBlock *BB,
if (Result.isConstant()) if (Result.isConstant())
return Result.getConstant(); return Result.getConstant();
if (Result.isConstantRange()) { if (Result.isConstantRange()) {
ConstantRange CR = Result.getConstantRange(); const ConstantRange &CR = Result.getConstantRange();
if (const APInt *SingleVal = CR.getSingleElement()) if (const APInt *SingleVal = CR.getSingleElement())
return ConstantInt::get(V->getContext(), *SingleVal); return ConstantInt::get(V->getContext(), *SingleVal);
} }
@ -1686,7 +1686,7 @@ Constant *LazyValueInfo::getConstantOnEdge(Value *V, BasicBlock *FromBB,
if (Result.isConstant()) if (Result.isConstant())
return Result.getConstant(); return Result.getConstant();
if (Result.isConstantRange()) { if (Result.isConstantRange()) {
ConstantRange CR = Result.getConstantRange(); const ConstantRange &CR = Result.getConstantRange();
if (const APInt *SingleVal = CR.getSingleElement()) if (const APInt *SingleVal = CR.getSingleElement())
return ConstantInt::get(V->getContext(), *SingleVal); return ConstantInt::get(V->getContext(), *SingleVal);
} }
@ -1712,7 +1712,7 @@ static LazyValueInfo::Tristate getPredicateResult(unsigned Pred, Constant *C,
ConstantInt *CI = dyn_cast<ConstantInt>(C); ConstantInt *CI = dyn_cast<ConstantInt>(C);
if (!CI) return LazyValueInfo::Unknown; if (!CI) return LazyValueInfo::Unknown;
ConstantRange CR = Result.getConstantRange(); const ConstantRange &CR = Result.getConstantRange();
if (Pred == ICmpInst::ICMP_EQ) { if (Pred == ICmpInst::ICMP_EQ) {
if (!CR.contains(CI->getValue())) if (!CR.contains(CI->getValue()))
return LazyValueInfo::False; return LazyValueInfo::False;