Use the simpler version of llvm::sys::fs::remove when possible.

llvm-svn: 198957
This commit is contained in:
Rafael Espindola 2014-01-10 21:32:14 +00:00
parent c0a5d5bc4f
commit 2a008784d3
6 changed files with 10 additions and 19 deletions

View File

@ -36,8 +36,7 @@ void FileRemapper::clear(StringRef outputDir) {
assert(ToFromMappings.empty());
if (!outputDir.empty()) {
std::string infoFile = getRemapInfoFile(outputDir);
bool existed;
llvm::sys::fs::remove(infoFile, existed);
llvm::sys::fs::remove(infoFile);
}
}

View File

@ -2591,8 +2591,7 @@ bool ASTUnit::Save(StringRef File) {
}
if (llvm::sys::fs::rename(TempPath.str(), File)) {
bool exists;
llvm::sys::fs::remove(TempPath.str(), exists);
llvm::sys::fs::remove(TempPath.str());
return true;
}

View File

@ -432,8 +432,7 @@ void CompilerInstance::clearOutputFiles(bool EraseFiles) {
delete it->OS;
if (!it->TempFilename.empty()) {
if (EraseFiles) {
bool existed;
llvm::sys::fs::remove(it->TempFilename, existed);
llvm::sys::fs::remove(it->TempFilename);
} else {
SmallString<128> NewOutFile(it->Filename);
@ -445,8 +444,7 @@ void CompilerInstance::clearOutputFiles(bool EraseFiles) {
getDiagnostics().Report(diag::err_unable_to_rename_temp)
<< it->TempFilename << it->Filename << ec.message();
bool existed;
llvm::sys::fs::remove(it->TempFilename, existed);
llvm::sys::fs::remove(it->TempFilename);
}
}
} else if (!it->Filename.empty() && EraseFiles)
@ -1091,10 +1089,8 @@ static void pruneModuleCache(const HeaderSearchOptions &HSOpts) {
// If we removed all of the files in the directory, remove the directory
// itself.
if (RemovedAllFiles) {
bool Existed;
llvm::sys::fs::remove(Dir->path(), Existed);
}
if (RemovedAllFiles)
llvm::sys::fs::remove(Dir->path());
}
}

View File

@ -166,8 +166,7 @@ static void PrintFilename(raw_ostream &OS, StringRef Filename) {
void DependencyFileCallback::OutputDependencyFile() {
if (SeenMissingHeader) {
bool existed;
llvm::sys::fs::remove(OutputFile, existed);
llvm::sys::fs::remove(OutputFile);
return;
}

View File

@ -458,10 +458,9 @@ public:
AllWritten = false;
Diagnostics.Report(clang::diag::err_unable_to_rename_temp)
<< TempFilename << Filename << ec.message();
bool existed;
// If the remove fails, there's not a lot we can do - this is already an
// error.
llvm::sys::fs::remove(TempFilename.str(), existed);
llvm::sys::fs::remove(TempFilename.str());
}
}

View File

@ -807,13 +807,12 @@ GlobalModuleIndex::writeIndex(FileManager &FileMgr, StringRef Path) {
return EC_IOError;
// Remove the old index file. It isn't relevant any more.
bool OldIndexExisted;
llvm::sys::fs::remove(IndexPath.str(), OldIndexExisted);
llvm::sys::fs::remove(IndexPath.str());
// Rename the newly-written index file to the proper name.
if (llvm::sys::fs::rename(IndexTmpPath.str(), IndexPath.str())) {
// Rename failed; just remove the
llvm::sys::fs::remove(IndexTmpPath.str(), OldIndexExisted);
llvm::sys::fs::remove(IndexTmpPath.str());
return EC_IOError;
}