forked from OSchip/llvm-project
Fix a buffer overflow noticed by gcc-4.6: zero is written into
SmallArray[SmallSize] in the SmallPtrSetIteratorImpl, and this is one off the end of the array. For those who care, right now gcc warns about writing off the end because it is confused about the declaration of SmallArray as having length 1 in the parent class SmallPtrSetIteratorImpl. However if you tweak code to unconfuse it, then it still warns about writing off the end of the array, because of this buffer overflow. In short, even with this fix gcc-4.6 will warn about writing off the end of the array, but now that is only because it is confused. llvm-svn: 107200
This commit is contained in:
parent
585c38e776
commit
29933505b6
|
@ -233,7 +233,7 @@ template<class PtrType, unsigned SmallSize>
|
|||
class SmallPtrSet : public SmallPtrSetImpl {
|
||||
// Make sure that SmallSize is a power of two, round up if not.
|
||||
enum { SmallSizePowTwo = NextPowerOfTwo<SmallSize>::Val };
|
||||
void *SmallArray[SmallSizePowTwo];
|
||||
void *SmallArray[SmallSizePowTwo+1];
|
||||
typedef PointerLikeTypeTraits<PtrType> PtrTraits;
|
||||
public:
|
||||
SmallPtrSet() : SmallPtrSetImpl(SmallSizePowTwo) {}
|
||||
|
|
Loading…
Reference in New Issue