maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[llvm-diff] Implement diff of PHI nodes 

Implement diff of PHI nodes

Reviewed By: dblaikie

Differential Revision: https://reviews.llvm.org/D114211
This commit is contained in:
Bill Wendling 2021-11-22 13:21:24 -08:00 committed by Bill Wendling
parent 6149e57dc1
commit 2975f37d8d
2 changed files with 51 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
llvm/test/tools/llvm-diff/phinode.ll Normal file
View File

@ -0,0 +1,28 @@
; RUN: rm -f %t.ll
; RUN: cat %s | sed -e 's/ 0, %2 / 1, %2 /' > %t.ll
; RUN: not llvm-diff %s %t.ll 2>&1 | FileCheck %s
; CHECK: in function foo:
; CHECK-NEXT: in block %6 / %6:
; CHECK-NEXT: > %7 = phi i32 [ 1, %2 ], [ -1, %1 ]
; CHECK-NEXT: > ret i32 %7
; CHECK-NEXT: < %7 = phi i32 [ 0, %2 ], [ -1, %1 ]
; CHECK-NEXT: < ret i32 %7
define i32 @foo(i32 %0) #0 {
callbr void asm sideeffect "", "X,~{dirflag},~{fpsr},~{flags}"(i8* blockaddress(@foo, %6))
to label %2 [label %6]
2:
%3 = icmp eq i32 %0, 0
br i1 %3, label %6, label %4
4:
br label %5
5:
br label %5
6:
%7 = phi i32 [ 0, %2 ], [ -1, %1 ]
ret i32 %7
}

26
llvm/tools/llvm-diff/lib/DifferenceEngine.cpp
View File

@ -269,15 +269,35 @@ class FunctionDifferenceEngine {
} else if (isa<CallInst>(L)) {
return diffCallSites(cast<CallInst>(*L), cast<CallInst>(*R), Complain);
} else if (isa<PHINode>(L)) {
// FIXME: implement.
const PHINode &LI = cast<PHINode>(*L);
const PHINode &RI = cast<PHINode>(*R);
// This is really weird; type uniquing is broken?
if (L->getType() != R->getType()) {
if (!L->getType()->isPointerTy() || !R->getType()->isPointerTy()) {
if (LI.getType() != RI.getType()) {
if (!LI.getType()->isPointerTy() || !RI.getType()->isPointerTy()) {
if (Complain) Engine.log("different phi types");
return true;
}
}
if (LI.getNumIncomingValues() != RI.getNumIncomingValues()) {
if (Complain)
Engine.log("PHI node # of incoming values differ");
return true;
}
for (unsigned I = 0; I < LI.getNumIncomingValues(); ++I) {
if (TryUnify)
tryUnify(LI.getIncomingBlock(I), RI.getIncomingBlock(I));
if (!equivalentAsOperands(LI.getIncomingValue(I),
RI.getIncomingValue(I))) {
if (Complain)
Engine.log("PHI node incoming values differ");
return true;
}
}
return false;
// Terminators.