eliminate an argument from PrintRelDirective, sinking

the one special case into EmitSectionOffset.  MCize
the non-special case in EmitSectionOffset.

llvm-svn: 98014
This commit is contained in:
Chris Lattner 2010-03-09 00:17:58 +00:00
parent f6fb1e0d93
commit 292ec6c299
2 changed files with 17 additions and 12 deletions

View File

@ -77,10 +77,8 @@ unsigned DwarfPrinter::SizeOfEncodedValue(unsigned Encoding) const {
return 0;
}
void DwarfPrinter::PrintRelDirective(bool Force32Bit, bool isInSection) const {
if (isInSection && MAI->getDwarfSectionOffsetDirective())
O << MAI->getDwarfSectionOffsetDirective();
else if (Force32Bit || TD->getPointerSize() == sizeof(int32_t))
void DwarfPrinter::PrintRelDirective(bool Force32Bit) const {
if (Force32Bit || TD->getPointerSize() == sizeof(int32_t))
O << MAI->getData32bitsDirective();
else
O << MAI->getData64bitsDirective();
@ -253,17 +251,23 @@ void DwarfPrinter::EmitDifference(const MCSymbol *TagHi, const MCSymbol *TagLo,
void DwarfPrinter::EmitSectionOffset(const MCSymbol *Label,
const MCSymbol *Section,
bool IsSmall, bool isEH) {
bool printAbsolute = false;
bool isAbsolute;
if (isEH)
printAbsolute = MAI->isAbsoluteEHSectionOffsets();
isAbsolute = MAI->isAbsoluteEHSectionOffsets();
else
printAbsolute = MAI->isAbsoluteDebugSectionOffsets();
isAbsolute = MAI->isAbsoluteDebugSectionOffsets();
if (!printAbsolute)
if (!isAbsolute)
return EmitDifference(Label, Section, IsSmall);
PrintRelDirective(IsSmall, true);
PrintLabelName(Label);
// On COFF targets, we have to emit the weird .secrel32 directive.
if (const char *SecOffDir = MAI->getDwarfSectionOffsetDirective())
O << SecOffDir << Label->getName();
else {
unsigned Size = IsSmall ? 4 : TD->getPointerSize();
Asm->OutStreamer.EmitValue(MCSymbolRefExpr::Create(Label, Asm->OutContext),
Size, 0/*AddrSpace*/);
}
}
/// EmitFrameMoves - Emit frame instructions to describe the layout of the

View File

@ -89,8 +89,7 @@ public:
unsigned SizeOfEncodedValue(unsigned Encoding) const;
void PrintRelDirective(unsigned Encoding) const;
void PrintRelDirective(bool Force32Bit = false,
bool isInSection = false) const;
void PrintRelDirective(bool Force32Bit = false) const;
/// EOL - Print a newline character to asm stream. If a comment is present
/// then it will be printed first. Comments should not contain '\n'.
@ -130,6 +129,8 @@ public:
void EmitDifference(const MCSymbol *LabelHi, const MCSymbol *LabelLo,
bool IsSmall = false);
/// EmitSectionOffset - Emit Label-Section or use a special purpose directive
/// to emit a section offset if the target has one.
void EmitSectionOffset(const MCSymbol *Label, const MCSymbol *Section,
bool IsSmall = false, bool isEH = false);