maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[LLDB] Change RegisterValue::SetType param to const RegisterInfo& 

No one was pasing nullptr here.

Depends on D135670

Reviewed By: clayborg

Differential Revision: https://reviews.llvm.org/D135671
This commit is contained in:
David Spickett 2022-09-28 14:52:12 +00:00
parent 6faa345da9
commit 28e65a6a63
4 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lldb/include/lldb/Utility/RegisterValue.h
View File

@ -84,7 +84,7 @@ public:
void SetType(RegisterValue::Type type) { m_type = type; }
RegisterValue::Type SetType(const RegisterInfo *reg_info);
RegisterValue::Type SetType(const RegisterInfo &reg_info);
bool GetData(DataExtractor &data) const;

2
lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp
View File

@ -75,7 +75,7 @@ NativeRegisterContextLinux::WriteRegisterRaw(uint32_t reg_index,
memcpy(dst + (reg_info->byte_offset & 0x1), src, src_size);
// Set this full register as the value to write.
value_to_write.SetBytes(dst, full_value.GetByteSize(), byte_order);
value_to_write.SetType(full_reg_info);
value_to_write.SetType(*full_reg_info);
reg_to_write = full_reg;
}
}

2
lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp
View File

@ -136,7 +136,7 @@ NativeRegisterContextLinux_arm::ReadRegister(const RegisterInfo *reg_info,
// then use the type specified by reg_info rather than the uint64_t
// default
if (reg_value.GetByteSize() > reg_info->byte_size)
reg_value.SetType(reg_info);
reg_value.SetType(*reg_info);
}
return error;
}

5
lldb/source/Utility/RegisterValue.cpp
View File

@ -149,13 +149,12 @@ bool RegisterValue::GetScalarValue(Scalar &scalar) const {
void RegisterValue::Clear() { m_type = eTypeInvalid; }
RegisterValue::Type RegisterValue::SetType(const RegisterInfo *reg_info) {
assert(reg_info && "Expected non null reg_info.");
RegisterValue::Type RegisterValue::SetType(const RegisterInfo &reg_info) {
// To change the type, we simply copy the data in again, using the new format
RegisterValue copy;
DataExtractor copy_data;
if (copy.CopyValue(*this) && copy.GetData(copy_data)) {
Status error = SetValueFromData(*reg_info, copy_data, 0, true);
Status error = SetValueFromData(reg_info, copy_data, 0, true);
assert(error.Success() && "Expected SetValueFromData to succeed.");
UNUSED_IF_ASSERT_DISABLED(error);
}