maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Revert "[lld] Fix elf::unlinkAsync detached thread" 

This reverts commit 2694810153.

llvm-svn: 354080
This commit is contained in:
Nick Desaulniers 2019-02-14 23:39:32 +00:00
parent 19e95fe611
commit 289d70cf58
1 changed files with 2 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
lld/ELF/Filesystem.cpp
View File

@ -58,26 +58,9 @@ void elf::unlinkAsync(StringRef Path) {
std::error_code EC = sys::fs::openFileForRead(Path, FD);
sys::fs::remove(Path);
if (EC)
return;
// close and therefore remove TempPath in background.
std::mutex M;
std::condition_variable CV;
bool Started = false;
std::thread([&, FD] {
{
std::lock_guard<std::mutex> L(M);
Started = true;
CV.notify_all();
}
::close(FD);
}).detach();
// GLIBC 2.26 and earlier have race condition that crashes an entire process
// if the main thread calls exit(2) while other thread is starting up.
std::unique_lock<std::mutex> L(M);
CV.wait(L, [&] { return Started; });
if (!EC)
std::thread([=] { ::close(FD); }).detach();
#endif
}