maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Cache the simplified attributes in SimplifyAffineStructures to avoid redundant simplifications, as well as unnecessary accesses to the MLIRContext. 

PiperOrigin-RevId: 238654325
This commit is contained in:
River Riddle 2019-03-15 09:24:05 -07:00 committed by jpienaar
parent cdd56eb675
commit 27d1bb920e
1 changed files with 49 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

68
mlir/lib/Transforms/SimplifyAffineStructures.cpp
View File

@ -39,6 +39,50 @@ namespace {
struct SimplifyAffineStructures struct SimplifyAffineStructures
: public FunctionPass<SimplifyAffineStructures> { : public FunctionPass<SimplifyAffineStructures> {
void runOnFunction() override; void runOnFunction() override;
/// Utility to simplify an affine attribute and update its entry in the parent
/// instruction if necessary.
template <typename AttributeT>
void simplifyAndUpdateAttribute(Instruction *inst, Identifier name,
AttributeT attr) {
auto &simplified = simplifiedAttributes[attr];
if (simplified == attr)
return;
// This is a newly encountered attribute.
if (!simplified) {
// Try to simplify the value of the attribute.
auto value = attr.getValue();
auto simplifiedValue = simplify(value);
if (simplifiedValue == value) {
simplified = attr;
return;
}
simplified = AttributeT::get(simplifiedValue);
}
// Simplification was successful, so update the attribute.
inst->setAttr(name, simplified);
}
/// Performs basic integer set simplifications. Checks if it's empty, and
/// replaces it with the canonical empty set if it is.
IntegerSet simplify(IntegerSet set) {
FlatAffineConstraints fac(set);
if (fac.isEmpty())
return IntegerSet::getEmptySet(set.getNumDims(), set.getNumSymbols(),
set.getContext());
return set;
}
/// Performs basic affine map simplifications.
AffineMap simplify(AffineMap map) {
MutableAffineMap mMap(map);
mMap.simplify();
return mMap.getAffineMap();
}
DenseMap<Attribute, Attribute> simplifiedAttributes;
}; };
} // end anonymous namespace } // end anonymous namespace
@ -47,28 +91,14 @@ FunctionPassBase *mlir::createSimplifyAffineStructuresPass() {
return new SimplifyAffineStructures(); return new SimplifyAffineStructures();
} }
/// Performs basic integer set simplifications. Checks if it's empty, and
/// replaces it with the canonical empty set if it is.
static IntegerSet simplifyIntegerSet(IntegerSet set) {
FlatAffineConstraints fac(set);
if (fac.isEmpty())
return IntegerSet::getEmptySet(set.getNumDims(), set.getNumSymbols(),
set.getContext());
return set;
}
void SimplifyAffineStructures::runOnFunction() { void SimplifyAffineStructures::runOnFunction() {
simplifiedAttributes.clear();
getFunction()->walk([&](Instruction *opInst) { getFunction()->walk([&](Instruction *opInst) {
for (auto attr : opInst->getAttrs()) { for (auto attr : opInst->getAttrs()) {
if (auto mapAttr = attr.second.dyn_cast<AffineMapAttr>()) { if (auto mapAttr = attr.second.dyn_cast<AffineMapAttr>())
MutableAffineMap mMap(mapAttr.getValue()); simplifyAndUpdateAttribute(opInst, attr.first, mapAttr);
mMap.simplify(); else if (auto setAttr = attr.second.dyn_cast<IntegerSetAttr>())
auto map = mMap.getAffineMap(); simplifyAndUpdateAttribute(opInst, attr.first, setAttr);
opInst->setAttr(attr.first, AffineMapAttr::get(map));
} else if (auto setAttr = attr.second.dyn_cast<IntegerSetAttr>()) {
auto simplified = simplifyIntegerSet(setAttr.getValue());
opInst->setAttr(attr.first, IntegerSetAttr::get(simplified));
}
} }
}); });
} }