maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[ORC] Reset AsynchronousSymbolQuery's NotifySymbolsResolved callback on error. 

AsynchronousSymbolQuery::canStillFail checks the value of the callback to
prevent sending it redundant error notifications, so we need to reset it after
running it.

llvm-svn: 335664
This commit is contained in:
Lang Hames 2018-06-26 20:59:50 +00:00
parent 831c575829
commit 2795a0a06e
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
llvm/lib/ExecutionEngine/Orc/Core.cpp
View File

@ -196,13 +196,14 @@ void AsynchronousSymbolQuery::handleFailed(Error Err) {
assert(QueryRegistrations.empty() && ResolvedSymbols.empty() &&
NotYetResolvedCount == 0 && NotYetReadyCount == 0 &&
"Query should already have been abandoned");
if (NotifySymbolsResolved)
if (NotifySymbolsResolved) {
NotifySymbolsResolved(std::move(Err));
else {
NotifySymbolsResolved = SymbolsResolvedCallback();
} else {
assert(NotifySymbolsReady && "Failed after both callbacks issued?");
NotifySymbolsReady(std::move(Err));
NotifySymbolsReady = SymbolsReadyCallback();
}
NotifySymbolsReady = SymbolsReadyCallback();
}
void AsynchronousSymbolQuery::addQueryDependence(VSO &V, SymbolStringPtr Name) {