maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[Object/ELF] Don't confuse isDefined() and isCommon. 

Reported by Rafael Espindola. Pointy-hat to me.

llvm-svn: 239241
This commit is contained in:
Davide Italiano 2015-06-07 02:45:19 +00:00
parent 229a1e69fc
commit 2772b1d36d
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
llvm/include/llvm/Object/ELFTypes.h
View File

@ -180,14 +180,11 @@ struct Elf_Sym_Impl : Elf_Sym_Base<ELFT> {
bool isAbsolute() const { return st_shndx == ELF::SHN_ABS; }
bool isCommon() const {
return !isUndefined() &&
!(st_shndx >= ELF::SHN_LORESERVE && st_shndx < ELF::SHN_ABS);
return getType() == ELF::STT_COMMON || st_shndx == ELF::SHN_COMMON;
}
bool isDefined() const {
return !isUndefined() &&
(!(st_shndx >= ELF::SHN_LORESERVE &&
st_shndx <= ELF::SHN_HIRESERVE) ||
st_shndx == ELF::SHN_XINDEX);
!(st_shndx >= ELF::SHN_LORESERVE && st_shndx < ELF::SHN_ABS);
}
bool isProcessorSpecific() const {
return st_shndx >= ELF::SHN_LOPROC && st_shndx <= ELF::SHN_HIPROC;