maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[-Wunreachable-code] constexpr functions can be used as configuration values. 

llvm-svn: 204308
This commit is contained in:
Ted Kremenek 2014-03-20 06:07:35 +00:00
parent f3c93bb61b
commit 2766ad27e8
2 changed files with 27 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
clang/lib/Analysis/ReachableCode.cpp
View File

@ -139,6 +139,11 @@ static bool isConfigurationValue(const Stmt *S,
S = Ex->IgnoreParenCasts(); S = Ex->IgnoreParenCasts();
switch (S->getStmtClass()) { switch (S->getStmtClass()) {
case Stmt::CallExprClass: {
const FunctionDecl *Callee =
dyn_cast_or_null<FunctionDecl>(cast<CallExpr>(S)->getCalleeDecl());
return Callee ? Callee->isConstexpr() : false;
}
case Stmt::DeclRefExprClass: { case Stmt::DeclRefExprClass: {
const DeclRefExpr *DR = cast<DeclRefExpr>(S); const DeclRefExpr *DR = cast<DeclRefExpr>(S);
const ValueDecl *D = DR->getDecl(); const ValueDecl *D = DR->getDecl();

23
clang/test/SemaCXX/warn-unreachable.cpp
View File

@ -1,4 +1,4 @@
// RUN: %clang_cc1 %s -fcxx-exceptions -fexceptions -fsyntax-only -verify -fblocks -Wunreachable-code-aggressive -Wno-unused-value // RUN: %clang_cc1 %s -fcxx-exceptions -fexceptions -fsyntax-only -verify -fblocks -std=c++11 -Wunreachable-code-aggressive -Wno-unused-value
int &halt() __attribute__((noreturn)); int &halt() __attribute__((noreturn));
int &live(); int &live();
@ -234,3 +234,24 @@ Frobozz test_return_object_control_flow(int flag) {
return Frobozz(flag ? 42 : 24); // expected-warning {{code will never be executed}} return Frobozz(flag ? 42 : 24); // expected-warning {{code will never be executed}}
} }
void somethingToCall();
static constexpr bool isConstExprConfigValue() { return true; }
int test_const_expr_config_value() {
if (isConstExprConfigValue()) {
somethingToCall();
return 0;
}
somethingToCall(); // no-warning
return 1;
}
int test_const_expr_config_value_2() {
if (!isConstExprConfigValue()) {
somethingToCall(); // no-warning
return 0;
}
somethingToCall();
return 1;
}