[sanitizer] Intercept wordexp.

llvm-svn: 191305
This commit is contained in:
Evgeniy Stepanov 2013-09-24 14:38:22 +00:00
parent 2ed228b29b
commit 2761ee0409
7 changed files with 51 additions and 1 deletions

View File

@ -49,6 +49,7 @@
#include <pwd.h> #include <pwd.h>
#include <sys/socket.h> #include <sys/socket.h>
#include <netdb.h> #include <netdb.h>
#include <wordexp.h>
#if defined(__i386__) || defined(__x86_64__) #if defined(__i386__) || defined(__x86_64__)
# include <emmintrin.h> # include <emmintrin.h>
@ -2400,6 +2401,16 @@ TEST(MemorySanitizer, getgroups) {
EXPECT_NOT_POISONED(gids[i]); EXPECT_NOT_POISONED(gids[i]);
} }
TEST(MemorySanitizer, wordexp) {
wordexp_t w;
int res = wordexp("a b c", &w, 0);
ASSERT_EQ(0, res);
ASSERT_EQ(3, w.we_wordc);
ASSERT_STREQ("a", w.we_wordv[0]);
ASSERT_STREQ("b", w.we_wordv[1]);
ASSERT_STREQ("c", w.we_wordv[2]);
}
template<class T> template<class T>
static bool applySlt(T value, T shadow) { static bool applySlt(T value, T shadow) {
__msan_partial_poison(&value, &shadow, sizeof(T)); __msan_partial_poison(&value, &shadow, sizeof(T));

View File

@ -1995,6 +1995,29 @@ INTERCEPTOR(int, ppoll, __sanitizer_pollfd *fds, __sanitizer_nfds_t nfds,
#define INIT_PPOLL #define INIT_PPOLL
#endif #endif
#if SANITIZER_INTERCEPT_WORDEXP
INTERCEPTOR(int, wordexp, char *s, __sanitizer_wordexp_t *p, int flags) {
void *ctx;
COMMON_INTERCEPTOR_ENTER(ctx, wordexp, s, p, flags);
if (s) COMMON_INTERCEPTOR_READ_RANGE(ctx, s, REAL(strlen)(s) + 1);
int res = REAL(wordexp)(s, p, flags);
if (!res && p) {
COMMON_INTERCEPTOR_WRITE_RANGE(ctx, p, sizeof(*p));
if (p->we_wordc)
COMMON_INTERCEPTOR_WRITE_RANGE(ctx, p->we_wordv,
sizeof(*p->we_wordv) * p->we_wordc);
for (uptr i = 0; i < p->we_wordc; ++i) {
char *w = p->we_wordv[i];
if (w) COMMON_INTERCEPTOR_WRITE_RANGE(ctx, w, REAL(strlen)(w) + 1);
}
}
return res;
}
#define INIT_WORDEXP INTERCEPT_FUNCTION(wordexp);
#else
#define INIT_WORDEXP
#endif
#define SANITIZER_COMMON_INTERCEPTORS_INIT \ #define SANITIZER_COMMON_INTERCEPTORS_INIT \
INIT_STRCMP; \ INIT_STRCMP; \
INIT_STRNCMP; \ INIT_STRNCMP; \
@ -2063,4 +2086,5 @@ INTERCEPTOR(int, ppoll, __sanitizer_pollfd *fds, __sanitizer_nfds_t nfds,
INIT_SCANDIR64; \ INIT_SCANDIR64; \
INIT_GETGROUPS; \ INIT_GETGROUPS; \
INIT_POLL; \ INIT_POLL; \
INIT_PPOLL; INIT_PPOLL; \
INIT_WORDEXP;

View File

@ -118,5 +118,6 @@
# define SANITIZER_INTERCEPT_GETGROUPS SI_NOT_WINDOWS # define SANITIZER_INTERCEPT_GETGROUPS SI_NOT_WINDOWS
# define SANITIZER_INTERCEPT_POLL SI_NOT_WINDOWS # define SANITIZER_INTERCEPT_POLL SI_NOT_WINDOWS
# define SANITIZER_INTERCEPT_PPOLL SI_LINUX_NOT_ANDROID # define SANITIZER_INTERCEPT_PPOLL SI_LINUX_NOT_ANDROID
# define SANITIZER_INTERCEPT_WORDEXP SI_MAC || SI_LINUX_NOT_ANDROID
#endif // #ifndef SANITIZER_PLATFORM_INTERCEPTORS_H #endif // #ifndef SANITIZER_PLATFORM_INTERCEPTORS_H

View File

@ -42,6 +42,7 @@
#include <termios.h> #include <termios.h>
#include <time.h> #include <time.h>
#include <wchar.h> #include <wchar.h>
#include <wordexp.h>
#if SANITIZER_LINUX #if SANITIZER_LINUX
#include <utime.h> #include <utime.h>
@ -874,4 +875,9 @@ CHECK_TYPE_SIZE(__kernel_loff_t);
CHECK_TYPE_SIZE(__kernel_fd_set); CHECK_TYPE_SIZE(__kernel_fd_set);
#endif #endif
CHECK_TYPE_SIZE(wordexp_t);
CHECK_SIZE_AND_OFFSET(wordexp_t, we_wordc);
CHECK_SIZE_AND_OFFSET(wordexp_t, we_wordv);
CHECK_SIZE_AND_OFFSET(wordexp_t, we_offs);
#endif // SANITIZER_LINUX || SANITIZER_MAC #endif // SANITIZER_LINUX || SANITIZER_MAC

View File

@ -286,6 +286,12 @@ namespace __sanitizer {
extern unsigned path_max; extern unsigned path_max;
struct __sanitizer_wordexp_t {
uptr we_wordc;
char **we_wordv;
uptr we_offs;
};
#if SANITIZER_LINUX && !SANITIZER_ANDROID && \ #if SANITIZER_LINUX && !SANITIZER_ANDROID && \
(defined(__i386) || defined (__x86_64)) // NOLINT (defined(__i386) || defined (__x86_64)) // NOLINT
extern unsigned struct_user_regs_struct_sz; extern unsigned struct_user_regs_struct_sz;

View File

@ -361,6 +361,7 @@ void StatOutput(u64 *stat) {
name[StatInt_scandir] = " scandir "; name[StatInt_scandir] = " scandir ";
name[StatInt_scandir64] = " scandir64 "; name[StatInt_scandir64] = " scandir64 ";
name[StatInt_getgroups] = " getgroups "; name[StatInt_getgroups] = " getgroups ";
name[StatInt_wordexp] = " wordexp ";
name[StatAnnotation] = "Dynamic annotations "; name[StatAnnotation] = "Dynamic annotations ";
name[StatAnnotateHappensBefore] = " HappensBefore "; name[StatAnnotateHappensBefore] = " HappensBefore ";

View File

@ -356,6 +356,7 @@ enum StatType {
StatInt_scandir, StatInt_scandir,
StatInt_scandir64, StatInt_scandir64,
StatInt_getgroups, StatInt_getgroups,
StatInt_wordexp,
// Dynamic annotations. // Dynamic annotations.
StatAnnotation, StatAnnotation,