From 274506dab8bc7b754e750bc8a668c2b348aa5737 Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Thu, 3 May 2018 21:01:33 +0000 Subject: [PATCH] [CodeGenFunction] Use the StringRef::split function that takes a char separator instead of StringRef separator. NFC The char separator version should be a little better optimized. llvm-svn: 331482 --- clang/lib/CodeGen/CodeGenFunction.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/clang/lib/CodeGen/CodeGenFunction.cpp b/clang/lib/CodeGen/CodeGenFunction.cpp index bf5312550b79..6c73a8cebdc9 100644 --- a/clang/lib/CodeGen/CodeGenFunction.cpp +++ b/clang/lib/CodeGen/CodeGenFunction.cpp @@ -2284,7 +2284,7 @@ static bool hasRequiredFeatures(const SmallVectorImpl &ReqFeatures, return std::all_of( ReqFeatures.begin(), ReqFeatures.end(), [&](StringRef Feature) { SmallVector OrFeatures; - Feature.split(OrFeatures, "|"); + Feature.split(OrFeatures, '|'); return std::any_of(OrFeatures.begin(), OrFeatures.end(), [&](StringRef Feature) { if (!CallerFeatureMap.lookup(Feature)) { @@ -2322,7 +2322,7 @@ void CodeGenFunction::checkTargetFeatures(const CallExpr *E, // Return if the builtin doesn't have any required features. if (!FeatureList || StringRef(FeatureList) == "") return; - StringRef(FeatureList).split(ReqFeatures, ","); + StringRef(FeatureList).split(ReqFeatures, ','); if (!hasRequiredFeatures(ReqFeatures, CGM, FD, MissingFeature)) CGM.getDiags().Report(E->getLocStart(), diag::err_builtin_needs_feature) << TargetDecl->getDeclName()