[clang][driver] Remove an unused parameter. NFC.

- Group relevant code together.
This commit is contained in:
Michael Liao 2020-02-01 16:16:17 -05:00
parent a57dd66d5e
commit 268e57bd35
1 changed files with 8 additions and 9 deletions

View File

@ -3607,8 +3607,7 @@ static DwarfFissionKind getDebugFissionKind(const Driver &D,
static void RenderDebugOptions(const ToolChain &TC, const Driver &D, static void RenderDebugOptions(const ToolChain &TC, const Driver &D,
const llvm::Triple &T, const ArgList &Args, const llvm::Triple &T, const ArgList &Args,
bool EmitCodeView, bool IsWindowsMSVC, bool EmitCodeView, ArgStringList &CmdArgs,
ArgStringList &CmdArgs,
codegenoptions::DebugInfoKind &DebugInfoKind, codegenoptions::DebugInfoKind &DebugInfoKind,
DwarfFissionKind &DwarfFission) { DwarfFissionKind &DwarfFission) {
if (Args.hasFlag(options::OPT_fdebug_info_for_profiling, if (Args.hasFlag(options::OPT_fdebug_info_for_profiling,
@ -4651,8 +4650,8 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA,
AddClangCLArgs(Args, InputType, CmdArgs, &DebugInfoKind, &EmitCodeView); AddClangCLArgs(Args, InputType, CmdArgs, &DebugInfoKind, &EmitCodeView);
DwarfFissionKind DwarfFission; DwarfFissionKind DwarfFission;
RenderDebugOptions(TC, D, RawTriple, Args, EmitCodeView, IsWindowsMSVC, RenderDebugOptions(TC, D, RawTriple, Args, EmitCodeView, CmdArgs,
CmdArgs, DebugInfoKind, DwarfFission); DebugInfoKind, DwarfFission);
// Add the split debug info name to the command lines here so we // Add the split debug info name to the command lines here so we
// can propagate it to the backend. // can propagate it to the backend.
@ -5352,16 +5351,16 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA,
RawTriple.isOSDarwin() && !KernelOrKext)) RawTriple.isOSDarwin() && !KernelOrKext))
CmdArgs.push_back("-fregister-global-dtors-with-atexit"); CmdArgs.push_back("-fregister-global-dtors-with-atexit");
// -fms-extensions=0 is default.
if (Args.hasFlag(options::OPT_fms_extensions, options::OPT_fno_ms_extensions,
IsWindowsMSVC))
CmdArgs.push_back("-fms-extensions");
// -fno-use-line-directives is default. // -fno-use-line-directives is default.
if (Args.hasFlag(options::OPT_fuse_line_directives, if (Args.hasFlag(options::OPT_fuse_line_directives,
options::OPT_fno_use_line_directives, false)) options::OPT_fno_use_line_directives, false))
CmdArgs.push_back("-fuse-line-directives"); CmdArgs.push_back("-fuse-line-directives");
// -fms-extensions=0 is default.
if (Args.hasFlag(options::OPT_fms_extensions, options::OPT_fno_ms_extensions,
IsWindowsMSVC))
CmdArgs.push_back("-fms-extensions");
// -fms-compatibility=0 is default. // -fms-compatibility=0 is default.
bool IsMSVCCompat = Args.hasFlag( bool IsMSVCCompat = Args.hasFlag(
options::OPT_fms_compatibility, options::OPT_fno_ms_compatibility, options::OPT_fms_compatibility, options::OPT_fno_ms_compatibility,