maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Remove a premature invalidation of a threads pthread_t handle, thus avoiding 

a segfault when calling pthread_cancel.  Also, sets m_read_thread_enabled if
the thread is actually spawned.

Patch from Stephen Wilson.

llvm-svn: 109227
This commit is contained in:
Greg Clayton 2010-07-23 15:43:25 +00:00
parent 19503a2a78
commit 26661bca20
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lldb/source/Core/Communication.cpp
View File

@ -211,9 +211,9 @@ Communication::StartReadThread (Error *error_ptr)
char thread_name[1024];
snprintf(thread_name, sizeof(thread_name), "<lldb.comm.%s>", m_broadcaster_name.AsCString());
m_read_thread_enabled = true;
m_read_thread = Host::ThreadCreate (thread_name, Communication::ReadThread, this, error_ptr);
return m_read_thread != LLDB_INVALID_HOST_THREAD;
m_read_thread_enabled = m_read_thread != LLDB_INVALID_HOST_THREAD;
return m_read_thread_enabled;
}
bool
@ -232,6 +232,7 @@ Communication::StopReadThread (Error *error_ptr)
Host::ThreadCancel (m_read_thread, error_ptr);
return Host::ThreadJoin (m_read_thread, NULL, error_ptr);
m_read_thread = LLDB_INVALID_HOST_THREAD;
}
@ -339,7 +340,6 @@ Communication::ReadThread (void *p)
log->Printf ("%p Communication::ReadThread () thread exiting...", p);
// Let clients know that this thread is exiting
comm->m_read_thread = LLDB_INVALID_HOST_THREAD;
comm->BroadcastEvent (eBroadcastBitReadThreadDidExit);
return NULL;
}