[LLDB] Applying clang-tidy modernize-use-equals-default over LLDB

Applied modernize-use-equals-default clang-tidy check over LLDB.

This check is already present in the lldb/.clang-tidy config.

Differential Revision: https://reviews.llvm.org/D121844
This commit is contained in:
Shafik Yaghmour 2022-03-31 13:20:46 -07:00
parent 585c85abe5
commit 24f9a2f53d
41 changed files with 87 additions and 99 deletions

View File

@ -21,8 +21,7 @@ class MemoryRegionInfoListImpl {
public:
MemoryRegionInfoListImpl() : m_regions() {}
MemoryRegionInfoListImpl(const MemoryRegionInfoListImpl &rhs)
: m_regions(rhs.m_regions) {}
MemoryRegionInfoListImpl(const MemoryRegionInfoListImpl &rhs) = default;
MemoryRegionInfoListImpl &operator=(const MemoryRegionInfoListImpl &rhs) {
if (this == &rhs)

View File

@ -27,7 +27,7 @@ namespace lldb_private {
class QueueImpl {
public:
QueueImpl() {}
QueueImpl() = default;
QueueImpl(const lldb::QueueSP &queue_sp) { m_queue_wp = queue_sp; }

View File

@ -69,9 +69,7 @@ public:
}
}
ValueImpl(const ValueImpl &rhs)
: m_valobj_sp(rhs.m_valobj_sp), m_use_dynamic(rhs.m_use_dynamic),
m_use_synthetic(rhs.m_use_synthetic), m_name(rhs.m_name) {}
ValueImpl(const ValueImpl &rhs) = default;
ValueImpl &operator=(const ValueImpl &rhs) {
if (this != &rhs) {

View File

@ -19,9 +19,9 @@ using namespace lldb_private;
class ValueListImpl {
public:
ValueListImpl() {}
ValueListImpl() = default;
ValueListImpl(const ValueListImpl &rhs) : m_values(rhs.m_values) {}
ValueListImpl(const ValueListImpl &rhs) = default;
ValueListImpl &operator=(const ValueListImpl &rhs) {
if (this == &rhs)

View File

@ -179,7 +179,7 @@ public:
class BreakpointDummyOptionGroup : public OptionGroup {
public:
BreakpointDummyOptionGroup() {}
BreakpointDummyOptionGroup() = default;
~BreakpointDummyOptionGroup() override = default;
@ -252,7 +252,7 @@ public:
class CommandOptions : public OptionGroup {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
@ -1118,7 +1118,7 @@ public:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
@ -1249,7 +1249,7 @@ public:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
@ -1401,7 +1401,7 @@ public:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
@ -1618,7 +1618,7 @@ public:
class BreakpointAccessOptionGroup : public OptionGroup {
public:
BreakpointAccessOptionGroup() {}
BreakpointAccessOptionGroup() = default;
~BreakpointAccessOptionGroup() override = default;
@ -2059,7 +2059,7 @@ public:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
@ -2255,7 +2255,7 @@ public:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;

View File

@ -281,7 +281,7 @@ are no syntax errors may indicate that a function was declared but never called.
class CommandOptions : public OptionGroup {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
@ -501,7 +501,7 @@ public:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;

View File

@ -206,7 +206,7 @@ class CommandObjectCommandsAlias : public CommandObjectRaw {
protected:
class CommandOptions : public OptionGroup {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
@ -1022,7 +1022,7 @@ private:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
@ -1267,7 +1267,7 @@ public:
protected:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
@ -1422,7 +1422,7 @@ public:
protected:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
@ -1880,7 +1880,7 @@ public:
protected:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;

View File

@ -24,7 +24,7 @@
using namespace lldb;
using namespace lldb_private;
CommandObjectExpression::CommandOptions::CommandOptions() {}
CommandObjectExpression::CommandOptions::CommandOptions() = default;
CommandObjectExpression::CommandOptions::~CommandOptions() = default;

View File

@ -726,7 +726,7 @@ class CommandObjectFrameRecognizerAdd : public CommandObjectParsed {
private:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
Status SetOptionValue(uint32_t option_idx, llvm::StringRef option_arg,

View File

@ -75,7 +75,7 @@ public:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;

View File

@ -1186,7 +1186,7 @@ class CommandObjectMemoryWrite : public CommandObjectParsed {
public:
class OptionGroupWriteMemory : public OptionGroup {
public:
OptionGroupWriteMemory() {}
OptionGroupWriteMemory() = default;
~OptionGroupWriteMemory() override = default;

View File

@ -138,7 +138,7 @@ class CommandObjectMemoryTagWrite : public CommandObjectParsed {
public:
class OptionGroupTagWrite : public OptionGroup {
public:
OptionGroupTagWrite() {}
OptionGroupTagWrite() = default;
~OptionGroupTagWrite() override = default;

View File

@ -600,7 +600,7 @@ public:
protected:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
@ -692,7 +692,7 @@ public:
protected:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
@ -1315,7 +1315,7 @@ protected:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
@ -1679,7 +1679,7 @@ class CommandObjectPlatformShell : public CommandObjectRaw {
public:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;

View File

@ -1214,7 +1214,7 @@ public:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
@ -1317,7 +1317,7 @@ public:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;

View File

@ -223,7 +223,7 @@ public:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
@ -351,7 +351,7 @@ public:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;

View File

@ -86,7 +86,7 @@ insert-before or insert-after.");
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
@ -329,7 +329,7 @@ public:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
@ -427,7 +427,7 @@ public:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;

View File

@ -36,7 +36,7 @@ using namespace lldb_private;
class CommandObjectSourceInfo : public CommandObjectParsed {
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
@ -623,7 +623,7 @@ protected:
class CommandObjectSourceList : public CommandObjectParsed {
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
@ -755,7 +755,7 @@ protected:
SourceInfo(ConstString name, const LineEntry &line_entry)
: function(name), line_entry(line_entry) {}
SourceInfo() {}
SourceInfo() = default;
bool IsValid() const { return (bool)function && line_entry.IsValid(); }

View File

@ -1936,7 +1936,7 @@ public:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
@ -2841,7 +2841,7 @@ class CommandObjectTargetModulesList : public CommandObjectParsed {
public:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
@ -3183,7 +3183,7 @@ public:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;

View File

@ -286,7 +286,7 @@ class CommandObjectTypeSynthAdd : public CommandObjectParsed,
private:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
@ -498,7 +498,7 @@ class CommandObjectTypeFormatAdd : public CommandObjectParsed {
private:
class CommandOptions : public OptionGroup {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
@ -707,7 +707,7 @@ class CommandObjectTypeFormatterDelete : public CommandObjectParsed {
protected:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
@ -872,7 +872,7 @@ class CommandObjectTypeFormatterClear : public CommandObjectParsed {
private:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
@ -1815,7 +1815,7 @@ protected:
class CommandObjectTypeCategoryEnable : public CommandObjectParsed {
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
@ -1992,7 +1992,7 @@ protected:
class CommandObjectTypeCategoryDisable : public CommandObjectParsed {
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
@ -2405,7 +2405,7 @@ private:
typedef std::vector<std::string> option_vector;
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
@ -2661,7 +2661,7 @@ protected:
class CommandOptions : public OptionGroup {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;

View File

@ -164,7 +164,7 @@ public:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
@ -454,7 +454,7 @@ public:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
@ -577,7 +577,7 @@ public:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;
@ -702,7 +702,7 @@ public:
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;

View File

@ -313,7 +313,7 @@ are no syntax errors may indicate that a function was declared but never called.
class CommandOptions : public Options {
public:
CommandOptions() {}
CommandOptions() = default;
~CommandOptions() override = default;

View File

@ -2282,7 +2282,7 @@ protected:
class FormDelegate {
public:
FormDelegate() {}
FormDelegate() = default;
virtual ~FormDelegate() = default;
@ -3644,7 +3644,7 @@ protected:
class SearcherDelegate {
public:
SearcherDelegate() {}
SearcherDelegate() = default;
virtual ~SearcherDelegate() = default;

View File

@ -12,7 +12,7 @@
CFCData::CFCData(CFDataRef data) : CFCReleaser<CFDataRef>(data) {}
// CFCData copy constructor
CFCData::CFCData(const CFCData &rhs) : CFCReleaser<CFDataRef>(rhs) {}
CFCData::CFCData(const CFCData &rhs) = default;
// CFCData copy constructor
CFCData &CFCData::operator=(const CFCData &rhs)

View File

@ -14,11 +14,10 @@ CFCMutableArray::CFCMutableArray(CFMutableArrayRef s)
: CFCReleaser<CFMutableArrayRef>(s) {}
// CFCMutableArray copy constructor
CFCMutableArray::CFCMutableArray(const CFCMutableArray &rhs)
: CFCReleaser<CFMutableArrayRef>(rhs) // NOTE: this won't make a copy of the
// array, just add a new reference to
// it
{}
CFCMutableArray::CFCMutableArray(const CFCMutableArray &rhs) =
default; // NOTE: this won't make a copy of the
// array, just add a new reference to
// it
// CFCMutableArray copy constructor
CFCMutableArray &CFCMutableArray::operator=(const CFCMutableArray &rhs) {

View File

@ -13,8 +13,8 @@ CFCMutableDictionary::CFCMutableDictionary(CFMutableDictionaryRef s)
: CFCReleaser<CFMutableDictionaryRef>(s) {}
// CFCMutableDictionary copy constructor
CFCMutableDictionary::CFCMutableDictionary(const CFCMutableDictionary &rhs)
: CFCReleaser<CFMutableDictionaryRef>(rhs) {}
CFCMutableDictionary::CFCMutableDictionary(const CFCMutableDictionary &rhs) =
default;
// CFCMutableDictionary copy constructor
const CFCMutableDictionary &CFCMutableDictionary::

View File

@ -14,8 +14,7 @@ CFCMutableSet::CFCMutableSet(CFMutableSetRef s)
: CFCReleaser<CFMutableSetRef>(s) {}
// CFCMutableSet copy constructor
CFCMutableSet::CFCMutableSet(const CFCMutableSet &rhs)
: CFCReleaser<CFMutableSetRef>(rhs) {}
CFCMutableSet::CFCMutableSet(const CFCMutableSet &rhs) = default;
// CFCMutableSet copy constructor
const CFCMutableSet &CFCMutableSet::operator=(const CFCMutableSet &rhs) {

View File

@ -14,7 +14,7 @@
CFCString::CFCString(CFStringRef s) : CFCReleaser<CFStringRef>(s) {}
// CFCString copy constructor
CFCString::CFCString(const CFCString &rhs) : CFCReleaser<CFStringRef>(rhs) {}
CFCString::CFCString(const CFCString &rhs) = default;
// CFCString copy constructor
CFCString &CFCString::operator=(const CFCString &rhs) {

View File

@ -806,7 +806,7 @@ void ClangASTImporter::ForgetSource(clang::ASTContext *dst_ast,
md->removeOriginsWithContext(src_ast);
}
ClangASTImporter::MapCompleter::~MapCompleter() {}
ClangASTImporter::MapCompleter::~MapCompleter() = default;
llvm::Expected<Decl *>
ClangASTImporter::ASTImporterDelegate::ImportImpl(Decl *From) {

View File

@ -19,7 +19,7 @@ ClangREPL::ClangREPL(lldb::LanguageType language, Target &target)
: REPL(eKindClang, target), m_language(language),
m_implicit_expr_result_regex("\\$[0-9]+") {}
ClangREPL::~ClangREPL() {}
ClangREPL::~ClangREPL() = default;
void ClangREPL::Initialize() {
LanguageSet languages;

View File

@ -19,9 +19,7 @@ using namespace lldb_private;
ExecutionContext::ExecutionContext()
: m_target_sp(), m_process_sp(), m_thread_sp(), m_frame_sp() {}
ExecutionContext::ExecutionContext(const ExecutionContext &rhs)
: m_target_sp(rhs.m_target_sp), m_process_sp(rhs.m_process_sp),
m_thread_sp(rhs.m_thread_sp), m_frame_sp(rhs.m_frame_sp) {}
ExecutionContext::ExecutionContext(const ExecutionContext &rhs) = default;
ExecutionContext::ExecutionContext(const lldb::TargetSP &target_sp,
bool get_process)
@ -414,9 +412,8 @@ ExecutionContextRef::ExecutionContextRef(Target *target, bool adopt_selected)
}
ExecutionContextRef::ExecutionContextRef(const ExecutionContextRef &rhs)
: m_target_wp(rhs.m_target_wp), m_process_wp(rhs.m_process_wp),
m_thread_wp(rhs.m_thread_wp), m_tid(rhs.m_tid),
m_stack_id(rhs.m_stack_id) {}
= default;
ExecutionContextRef &ExecutionContextRef::
operator=(const ExecutionContextRef &rhs) {

View File

@ -54,10 +54,7 @@ XcodeSDK::XcodeSDK(XcodeSDK::Info info) : m_name(GetName(info.type).str()) {
}
}
XcodeSDK &XcodeSDK::operator=(const XcodeSDK &other) {
m_name = other.m_name;
return *this;
}
XcodeSDK &XcodeSDK::operator=(const XcodeSDK &other) = default;
bool XcodeSDK::operator==(const XcodeSDK &other) {
return m_name == other.m_name;

View File

@ -25,7 +25,7 @@ DNBBreakpoint::DNBBreakpoint(nub_addr_t addr, nub_size_t byte_size,
m_is_watchpoint(0), m_watch_read(0), m_watch_write(0),
m_hw_index(INVALID_NUB_HW_INDEX) {}
DNBBreakpoint::~DNBBreakpoint() {}
DNBBreakpoint::~DNBBreakpoint() = default;
void DNBBreakpoint::Dump() const {
if (IsBreakpoint()) {
@ -45,9 +45,9 @@ void DNBBreakpoint::Dump() const {
#pragma mark-- DNBBreakpointList
DNBBreakpointList::DNBBreakpointList() {}
DNBBreakpointList::DNBBreakpointList() = default;
DNBBreakpointList::~DNBBreakpointList() {}
DNBBreakpointList::~DNBBreakpointList() = default;
DNBBreakpoint *DNBBreakpointList::Add(nub_addr_t addr, nub_size_t length,
bool hardware) {

View File

@ -32,7 +32,7 @@ DNBDataRef::DNBDataRef(const uint8_t *start, size_t size, bool swap)
// Destructor
DNBDataRef::~DNBDataRef() {}
DNBDataRef::~DNBDataRef() = default;
// Get8
uint8_t DNBDataRef::Get8(offset_t *offset_ptr) const {

View File

@ -21,8 +21,7 @@ CFBundle::CFBundle(const char *path)
}
// CFBundle copy constructor
CFBundle::CFBundle(const CFBundle &rhs)
: CFReleaser<CFBundleRef>(rhs), m_bundle_url(rhs.m_bundle_url) {}
CFBundle::CFBundle(const CFBundle &rhs) = default;
// CFBundle copy constructor
CFBundle &CFBundle::operator=(const CFBundle &rhs) {
@ -32,7 +31,7 @@ CFBundle &CFBundle::operator=(const CFBundle &rhs) {
}
// Destructor
CFBundle::~CFBundle() {}
CFBundle::~CFBundle() = default;
// Set the path for a bundle by supplying a
bool CFBundle::SetPath(const char *path) {

View File

@ -18,7 +18,7 @@
CFString::CFString(CFStringRef s) : CFReleaser<CFStringRef>(s) {}
// CFString copy constructor
CFString::CFString(const CFString &rhs) : CFReleaser<CFStringRef>(rhs) {}
CFString::CFString(const CFString &rhs) = default;
// CFString copy constructor
CFString &CFString::operator=(const CFString &rhs) {
@ -36,7 +36,7 @@ CFString::CFString(const char *cstr, CFStringEncoding cstr_encoding)
}
// Destructor
CFString::~CFString() {}
CFString::~CFString() = default;
const char *CFString::GetFileSystemRepresentation(std::string &s) {
return CFString::FileSystemRepresentation(get(), s);

View File

@ -26,7 +26,7 @@ MachThreadList::MachThreadList()
: m_threads(), m_threads_mutex(PTHREAD_MUTEX_RECURSIVE),
m_is_64_bit(false) {}
MachThreadList::~MachThreadList() {}
MachThreadList::~MachThreadList() = default;
nub_state_t MachThreadList::GetState(nub_thread_t tid) {
MachThreadSP thread_sp(GetThreadByID(tid));

View File

@ -28,7 +28,7 @@ static const vm_size_t kInvalidPageSize = ~0;
MachVMMemory::MachVMMemory() : m_page_size(kInvalidPageSize), m_err(0) {}
MachVMMemory::~MachVMMemory() {}
MachVMMemory::~MachVMMemory() = default;
nub_size_t MachVMMemory::PageSize(task_t task) {
if (m_page_size == kInvalidPageSize) {

View File

@ -30,7 +30,7 @@ StdStringExtractor::StdStringExtractor(const char *packet_cstr)
}
// Destructor
StdStringExtractor::~StdStringExtractor() {}
StdStringExtractor::~StdStringExtractor() = default;
char StdStringExtractor::GetChar(char fail_value) {
if (m_index < m_packet.size()) {

View File

@ -18,7 +18,7 @@
TTYState::TTYState()
: m_fd(-1), m_tflags(-1), m_ttystateErr(-1), m_processGroup(-1) {}
TTYState::~TTYState() {}
TTYState::~TTYState() = default;
bool TTYState::GetTTYState(int fd, bool saveProcessGroup) {
if (fd >= 0 && ::isatty(fd)) {
@ -62,7 +62,7 @@ bool TTYState::SetTTYState() const {
TTYStateSwitcher::TTYStateSwitcher() : m_currentState(~0) {}
TTYStateSwitcher::~TTYStateSwitcher() {}
TTYStateSwitcher::~TTYStateSwitcher() = default;
bool TTYStateSwitcher::GetState(uint32_t idx, int fd, bool saveProcessGroup) {
if (ValidStateIndex(idx))

View File

@ -22,7 +22,7 @@
using namespace lldb_vscode;
StreamDescriptor::StreamDescriptor() {}
StreamDescriptor::StreamDescriptor() = default;
StreamDescriptor::StreamDescriptor(StreamDescriptor &&other) {
*this = std::move(other);

View File

@ -58,7 +58,7 @@ VSCode::VSCode()
log.reset(new std::ofstream(log_file_path));
}
VSCode::~VSCode() {}
VSCode::~VSCode() = default;
int64_t VSCode::GetLineForPC(int64_t sourceReference, lldb::addr_t pc) const {
auto pos = source_map.find(sourceReference);