maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Do not remove a target file in FileOutputBuffer::create(). 

FileOutputBuffer::create() attempts to remove a target file if the file
is a regular one, which results in an unexpected result in a failure
scenario.

If something goes wrong and the user of FileOutputBuffer decides to not
call commit(), it leaves nothing. An existing file is removed, and no
new file is created.

What we should do is to atomically replace an existing file with a new
file using rename(), so that it wouldn't remove an existing file without
creating a new one.

Differential Revision: https://reviews.llvm.org/D38283

llvm-svn: 314345
This commit is contained in:
Rui Ueyama 2017-09-27 21:19:24 +00:00
parent fa1ae3e862
commit 23fa4de2db
1 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
llvm/lib/Support/FileOutputBuffer.cpp
View File

@ -65,13 +65,6 @@ FileOutputBuffer::create(StringRef FilePath, size_t Size, unsigned Flags) {
IsRegular = false;
}
if (IsRegular) {
// Delete target file.
EC = sys::fs::remove(FilePath);
if (EC)
return EC;
}
SmallString<128> TempFilePath;
int FD;
if (IsRegular) {
@ -125,7 +118,7 @@ std::error_code FileOutputBuffer::commit() {
std::error_code EC;
if (IsRegular) {
// Rename file to final name.
// Atomically replace the existing file with the new one.
EC = sys::fs::rename(Twine(TempPath), Twine(FinalPath));
sys::DontRemoveFileOnSignal(TempPath);
} else {