From 2235bff2b916eb1564e17b39880687a19aaf50f3 Mon Sep 17 00:00:00 2001 From: Rui Ueyama Date: Wed, 13 Nov 2013 03:09:20 +0000 Subject: [PATCH] Use empty() instead of size() == 0. llvm-svn: 194551 --- lld/lib/Core/Resolver.cpp | 2 +- lld/lib/Driver/InputGraph.cpp | 4 ++-- lld/lib/Driver/WinLinkDriver.cpp | 2 +- lld/lib/ReaderWriter/ELF/SectionChunks.h | 2 +- lld/lib/ReaderWriter/MachO/StubsPass.hpp | 2 +- lld/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lld/lib/Core/Resolver.cpp b/lld/lib/Core/Resolver.cpp index 3af0c5cba717..d5531c262472 100644 --- a/lld/lib/Core/Resolver.cpp +++ b/lld/lib/Core/Resolver.cpp @@ -227,7 +227,7 @@ void Resolver::doDefinedAtom(const DefinedAtom &atom) { switch ( atom.sectionPosition() ) { case DefinedAtom::sectionPositionStart: case DefinedAtom::sectionPositionEnd: - assert(atom.size() == 0); + assert(atom.empty()); break; case DefinedAtom::sectionPositionEarly: case DefinedAtom::sectionPositionAny: diff --git a/lld/lib/Driver/InputGraph.cpp b/lld/lib/Driver/InputGraph.cpp index be7fea0c18cb..3f464618c9bf 100644 --- a/lld/lib/Driver/InputGraph.cpp +++ b/lld/lib/Driver/InputGraph.cpp @@ -133,7 +133,7 @@ uint32_t ControlNode::getResolveState() const { /// \brief Set the resolve state for the current element /// thats processed by the resolver. void ControlNode::setResolveState(uint32_t resolveState) { - if (_elements.size() == 0) + if (_elements.empty()) return; _elements[_currentElementIndex]->setResolveState(resolveState); } @@ -151,7 +151,7 @@ SimpleFileNode::SimpleFileNode(StringRef path, int64_t ordinal) /// of the input elements contained in the group. ErrorOr Group::getNextFile() { // If there are no elements, move on to the next input element - if (_elements.size() == 0) + if (_elements.empty()) return make_error_code(InputGraphError::no_more_files); for (;;) { diff --git a/lld/lib/Driver/WinLinkDriver.cpp b/lld/lib/Driver/WinLinkDriver.cpp index 9f692c1942b5..35cf6dd10d0f 100644 --- a/lld/lib/Driver/WinLinkDriver.cpp +++ b/lld/lib/Driver/WinLinkDriver.cpp @@ -911,7 +911,7 @@ WinLinkDriver::parse(int argc, const char *argv[], PECOFFLinkingContext &ctx, } } - if (inputElements.size() == 0 && !isReadingDirectiveSection) { + if (inputElements.empty() && !isReadingDirectiveSection) { diagnostics << "No input files\n"; return false; } diff --git a/lld/lib/ReaderWriter/ELF/SectionChunks.h b/lld/lib/ReaderWriter/ELF/SectionChunks.h index 0a0663ba8826..992db5c8daf3 100644 --- a/lld/lib/ReaderWriter/ELF/SectionChunks.h +++ b/lld/lib/ReaderWriter/ELF/SectionChunks.h @@ -576,7 +576,7 @@ StringTable::StringTable(const ELFLinkingContext &context, template uint64_t StringTable::addString(StringRef symname) { - if (symname.size() == 0) + if (symname.empty()) return 0; StringMapTIter stringIter = _stringMap.find(symname); if (stringIter == _stringMap.end()) { diff --git a/lld/lib/ReaderWriter/MachO/StubsPass.hpp b/lld/lib/ReaderWriter/MachO/StubsPass.hpp index a478b9e9794b..83afd7b1f1a4 100644 --- a/lld/lib/ReaderWriter/MachO/StubsPass.hpp +++ b/lld/lib/ReaderWriter/MachO/StubsPass.hpp @@ -123,7 +123,7 @@ public: virtual void addStubAtoms(MutableFile &mergedFile) { // Exit early if no stubs needed. - if ( _targetToStub.size() == 0 ) + if (_targetToStub.empty()) return; // Add all stubs to master file. for (auto it : _targetToStub) { diff --git a/lld/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp b/lld/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp index 9d7bbca89d6b..40bf988a9873 100644 --- a/lld/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp +++ b/lld/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp @@ -666,7 +666,7 @@ private: array = array.slice(3); } - if (array.size() == 0) + if (array.empty()) return ""; size_t len = 0;